Update Ldap.php to allow LDAP over SSL/TLS connections - #236
Merged
Merged
Conversation
This is a very crude workaround, a better solution is explained in the comments I added.
ssddanbrown
added a commit
that referenced
this pull request
Jan 14, 2017
As per details by fredericmohr in #236
Member
|
@fredericmohr Thanks for this and sorry it's taken me a while to getting round to merging your pull request. I have followed your comments and updated the ldap in 598b07b so that a protocol can be optionally specified without breaking. Port 636 or 389 will then be used, depending on protocol type, unless a port is specified by the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very crude workaround to allow LDAPS connections. A better solution would be the one explained in the comments.