Import thumbnail photos when LDAP users are created. - #2320
Merged
Merged
Conversation
ssddanbrown
added a commit
that referenced
this pull request
May 24, 2021
- Reduced options to single new configuration paramter instead of two. - Moved more logic into UserAvatars class. - Updated LDAP avatar import to also run on login when no image is currently set. - Added thumbnail fetching to search requests. - Added testing to cover. Related to PR #2320, and issue #1161
Member
|
Thanks a bunch for this @jasonhoule. Now merged for the next feature release. I followed this up with some changes in df0e03c. I removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My BookStack instance is using Active Directory for authentication. We wanted to be able to automatically import the user photos that we already have stored in Active Directory.
This change, controlled by config values in the config/services.php file, allows for user avatars to be imported from the LDAP thumbnailPhoto attribute. Users can still update their images from the profile page.