Skip to content

Fix the AddActivityIndexes migration's down() method - #2268

Merged
ssddanbrown merged 1 commit into
BookStackApp:masterfrom
gertjankrol:master
Sep 26, 2020
Merged

ssddanbrown merged 1 commit into
BookStackApp:masterfrom
gertjankrol:master

Conversation

@gertjankrol

Copy link
Copy Markdown
Contributor

This PR fixes artisan migration:rollback, which was broken due to incorrect index names in the 2020_09_19_094251_add_activity_indexes migration:

SQLSTATE[42000]: Syntax error or access violation: 1091 Can't DROP INDEX `key`; check that it exists (SQL: alter table `activities` drop index `key`)

@gertjankrol

Copy link
Copy Markdown
Contributor Author

Proposed a workflow to automatically test migrations in #2270

@ssddanbrown

Copy link
Copy Markdown
Member

Thanks for fixing this @gertjankrol, I really need to remember that index and dropIndex work in different ways. Merging in now for next patch release.

@ssddanbrown
ssddanbrown merged commit 49fa21c into BookStackApp:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants