Conversation
Member
|
Thank you very much for offering this PR @Ant1x and apologies for my very late reply. Also thank you for the clear detailed description for the options involved and what this was intended to cover. I've just merged in earlier PR #1998 which covers the same case so I'll therefore close this off. The changes will be part of the next patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using SAML IDP providers that have different authentication methods available, authentication will occasionally fail since by default the OneLogin SAML library sets
requestedAuthnContexttotrue.This has the effect of requiring the
exacturn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransportauthentication context from the IDP (Refer to README: https://github.com/onelogin/php-saml)I've been getting SAML to work with Microsoft ADFS that is configured with a range of different authentication mechanisms, and in this configuration ADFS is unable to authenticate a request that asks for
PasswordProtectedTransportIn this PR I have made this option configurable by setting
SAML2_REQUESTED_AUTHN_CONTEXTin the env config file. I have made it default totrueas to not change the current working configuration for already deployed Bookstack instances.Setting
SAML2_REQUESTED_AUTHN_CONTEXTtofalsewill send an authentication request to the IDP without specifying any authentication context, allowing the IDP to select the most appropriate method to authenticate the end user.Setting
SAML2_REQUESTED_AUTHN_CONTEXTtotrueor not configuring it will keep the same behavior of requestingPasswordProtectedTransport.(Note: The online GitHub editor has automatically added a newline to the .env.example.complete file)