Add close icon to notifications - #1845
Merged
ssddanbrown merged 1 commit intoJan 19, 2020
Merged
ssddanbrown merged 1 commit into
ssddanbrown merged 1 commit into
Conversation
Member
|
Thank you @SoarinFerret for this pull request, I'll merge in now for the next release. Just a note for the future, not a big issue here since this was a relatively small update, but if someone is assigned to an issue it's generally a good idea to comment on the issue to see if that person is intending to continue work on it. I probably need to make it clear in the readme that assignment is used to prevent work overlap. Thanks again though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to #1525
This adds a simple close icon to all notification panes. Here is an example of how it looks:
Per the comments on the bottom of the issue thread, it doesn't actually do anything, besides provide the user a visual cue reminding users to click to dismiss the notification.