Fix An Exception - #1793
Fix An Exception #1793
Conversation
…ble with Fideloper\Proxy\TrustProxies::handle"
|
Thank you for the pull request @abublihi. |
|
This issue appeared after the installation and configuration immediately, The issue did not appeare after I have installed the release branch, it only appears on the master branch. |
|
the error accord because of the version of fideloper/proxy packge version 3.3.4 /**
* Handle an incoming request.
*
* @param \Illuminate\Http\Request $request
* @param \Closure $next
*
* @throws \Symfony\Component\HttpKernel\Exception\HttpException
*
* @return mixed
*/
public function handle($request, Closure $next)
{
$this->setTrustedProxyHeaderNames($request);
$this->setTrustedProxyIpAddresses($request);
return $next($request);
}version 4.2.1 /**
* Handle an incoming request.
*
* @param \Illuminate\Http\Request $request
* @param \Closure $next
*
* @throws \Symfony\Component\HttpKernel\Exception\HttpException
*
* @return mixed
*/
public function handle(Request $request, Closure $next)
{
$request::setTrustedProxies([], $this->getTrustedHeaderNames()); // Reset trusted proxies between requests
$this->setTrustedProxyIpAddresses($request);
return $next($request);
} |
|
@abublihi Sure, I totally get what has changed and why this error might get thrown but I'm essentially curious as to why I have not seen this issue on my own system. Would you be able to confirm your exact PHP version and operating system? |
|
Yes you are right. Operating System: MacOs Sierra |
|
I never managed to find how an error would be thrown but I'll stop digging. Thank you again @abublihi for this change. Will merge in to be part of v0.28. |
2 participants
Fix an exception error