Skip to content

SAML2 Authentication - #1787

Merged
ssddanbrown merged 13 commits into
masterfrom
saml2_auth
Nov 17, 2019
Merged

ssddanbrown merged 13 commits into
masterfrom
saml2_auth

Conversation

@ssddanbrown

@ssddanbrown ssddanbrown commented Nov 16, 2019

Copy link
Copy Markdown
Member

Continuation of #1576.

TODO

  • Align config/env property names
  • Align config prop names
  • Testing of the core service & routes
  • Update of .env.complete with available options.
  • Add login icon, using a sensible name that can be overidden via the theme system if wished.
  • Update readme with attribution of libs used

Questionables

  • Do we need to consider multiple IDP usage? I'm tempted to say no for initial implementation but I'm worried we could be bitten by this. Maybe have a prefix to IDP-specific options now, Just as default?
    • Going to not worry about this for now, as we may be suiting the wrong requirement. Focus on single IDP.
  • Do we need the laravel library? Tempted to test usage of the OneLogin lib directly just so we don't have to rely on anther laravel-specific lib which adds another consideration on framework updates.
    • Removal now started

Considerations

  • Implementation of this will put pressure on the requirement of being able to disable the default auth. Don't want another large auth change in the release so will maybe need to queue that for release afterwards.
  • Since email auth will still be in place, users could reset their password via normal means until the above has been implemented.

Xiphoseer and others added 6 commits August 5, 2019 20:06
- Updated PHPdoc of SAML service to use type hinting instead.
- Updated groups to only sync if enabled.
- Updated names of some config props.
- Removed a couple of unused config props.
- Added exception to handle no email on SAML response.
@ssddanbrown ssddanbrown self-assigned this Nov 17, 2019
@ssddanbrown
ssddanbrown marked this pull request as ready for review November 17, 2019 19:19
@ssddanbrown
ssddanbrown merged commit 4e09656 into master Nov 17, 2019
@ssddanbrown ssddanbrown mentioned this pull request Nov 17, 2019
@ssddanbrown
ssddanbrown deleted the saml2_auth branch January 25, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants