Skip to content

Bugfix - download and assign avatar when creating LDAP user in database - #1746

Merged
ssddanbrown merged 1 commit into
BookStackApp:masterfrom
philjak:bugfix_create_avatar_for_ldap_login
Oct 29, 2019
Merged

ssddanbrown merged 1 commit into
BookStackApp:masterfrom
philjak:bugfix_create_avatar_for_ldap_login

Conversation

@philjak

@philjak philjak commented Oct 25, 2019

Copy link
Copy Markdown

Fixes issue #1161

@ssddanbrown

Copy link
Copy Markdown
Member

Hi @philjak,
Thank you for the pull request but I don't believe this addresses the issue fully?
I'm fairly sure the intention is for the avatar to be retrieved and saved from the LDAP system, not gravatar as this pull request enables.

@philjak

philjak commented Oct 27, 2019

Copy link
Copy Markdown
Author

Indeed - sorry. You're right. That PR does not pulll any avatar out of the LDAP system. But it fixes an issue, where even if you specify a particular AVATAR_URL, the avatar wasn't downloaded before, if the LDAP provider was used.

@ssddanbrown

Copy link
Copy Markdown
Member

@philjak Ah, Cool, Will therefore merge for next release.

@ssddanbrown
ssddanbrown merged commit bea983a into BookStackApp:master Oct 29, 2019
@philjak
philjak deleted the bugfix_create_avatar_for_ldap_login branch October 30, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants