Skip to content

Update Korean translation - #1734

Merged
ssddanbrown merged 5 commits into
BookStackApp:masterfrom
ististyle:master
Dec 27, 2019
Merged

ssddanbrown merged 5 commits into
BookStackApp:masterfrom
ististyle:master

Conversation

@ististyle

Copy link
Copy Markdown
Contributor

I filled in the missing parts, and I used more concise expressions throughout the translation to improve the consistency of terms.

User and others added 3 commits October 21, 2019 03:44
@ssddanbrown

Copy link
Copy Markdown
Member

Thank you for offering this pull request @ististudio.

I used Google translate on a few of the terms that have been changed, translating both the old text and the new text, and to be totally honest, the translation of the old text seemed to often match the original English intent.

On the translations that you have altered, Are the previous translations wrong in any way or is it a matter of preference or style? Sorry to be questioning this but it's just a little tricky to understand the changes without any knowledge of the language itself.

@ististyle

ististyle commented Oct 31, 2019

Copy link
Copy Markdown
Contributor Author

Some are by preference, some are about orthography. Unlike English, Korean tends to delete subjects. In particular, repeating a subject can sound awkward for Korean readers. I removed the subject if I could see it from the context. e.g. 'email_confirm_success' => 'Confirmation succeeded!'

Failure to distinguish "문서 만들기" from "문서 만듦" is a mistake in Google translation. Because a sentence ending with "-ᄆ" may have a similar meaning to that of a sentence in the present perfect tense, the latter means "The document has now been created." In addition, passive sentences that don't suit the Korean language have been changed into active ones.

Anyway, I tried not to lose any information given the context compared to the previous translation.

@hhk7734

hhk7734 commented Nov 5, 2019

Copy link
Copy Markdown

I think that some part of this commit is weird.

I'm not sure that using noun is proper for notification.
'페이지를 만들었습니다.' is more familiar(?) to me than '문서 만듦'.
and how many people can understand '장철'?

Google translation can do mistakes.
But, chosen words seem that people can use or understand well.

@ististyle

Copy link
Copy Markdown
Contributor Author

Thank you for your opinion, @hhk7734.

I used sentences ending in a noun only in activity.php for notifications. These expressions will be used in the box that is displayed in the following screenshot.

Screen Shot

It disappears in a few seconds. Because of that, I wanted people to read this at once and I used as few characters as possible. These uses themselves are not so unfamiliar in my book. I have also seen them on the Android OS from time to time.

I've seen "장, 절, 장절" being used in TeX, and I thought it was fine. But I agree that these terms look old. I'll change the term "장절" to "챕터" and "서적" to "책자".

If there are any other weird parts you think, I'd appreciate it if you let me know more.

@hhk7734

hhk7734 commented Nov 7, 2019

Copy link
Copy Markdown

@ististudio
I didn't know when the variables are used. After reading your explanation, I became to understand why you write that.

Others look fine.

@ssddanbrown ssddanbrown added this to the v0.28.0 milestone Dec 27, 2019
@ssddanbrown

Copy link
Copy Markdown
Member

Thanks @hhk7734 for giving these a look and thanks again @ististudio for offering these updates.

Will merge now to be part of the next release.

@ssddanbrown
ssddanbrown merged commit dabe79a into BookStackApp:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants