Fix 1575 - #1587
Merged
Merged
Fix 1575#1587
Conversation
Member
|
Hi @james-geiger, I did revert the codemirror line wrapping changes, at least for now, since this change could have quite an effect of how people's content would be displayed and I think further discussion would be needed to determine if wrapped is the better approach. |
This was referenced Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addressed the problem in #1575 where inline code will overflow off the page. Added line wrapping in codemirror block. Could refactor this into a setting or remove if it doesn't fit into the overall design.