Hide permissions table unless custom permissions are enabled - #1505
Merged
ssddanbrown merged 1 commit intoJun 25, 2019
Merged
ssddanbrown merged 1 commit into
ssddanbrown merged 1 commit into
Conversation
Member
|
Neatly implemented, thanks @timoschwarzer. Eventually I want to change the permissions system to be sensible so you selectively add roles to permit/deny but that is on the roadmap for the future, as this is a nice UX improvement until then. Will merge for the next feature release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just spent too much time figuring out why my custom permissions were not working. Turned out I didn't enable them.
This PR hides the permissions table unless you enable custom permissions. That should save some time and frustration for users who apparently cannot read (like me 😄).