Skip to content

add missing translations to german language file - #1503

Closed
ezzra wants to merge 3 commits into
BookStackApp:releasefrom
ezzra:german_language
Closed

ezzra wants to merge 3 commits into
BookStackApp:releasefrom
ezzra:german_language

Conversation

@ezzra

@ezzra ezzra commented Jun 21, 2019

Copy link
Copy Markdown

this adds missing translations for german language, there might come some more, so just keep it open

@timoschwarzer timoschwarzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translations LGTM 👍

@ssddanbrown ssddanbrown added this to the v0.27.0 milestone Jun 25, 2019
@ssddanbrown

Copy link
Copy Markdown
Member

Thank you very much for this in addition to the good find on #1502. Would you be able to offer these changes on a branch of master, Targeting merge into master?

The release branch is designed to be untouched apart from when deploying a release.

@ssddanbrown ssddanbrown modified the milestones: v0.27.0, v0.28.0 Aug 26, 2019

@philjak philjak left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'accord

@ssddanbrown

Copy link
Copy Markdown
Member

Closing since these changes have effectively already been made via other means, and manually cherry-picking these changes into master led to no change.

Thanks again though @ezzra for offering these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants