Skip to content

Update Dutch password_hint translation to correspond with validation - #1314

Merged
ssddanbrown merged 1 commit into
BookStackApp:masterfrom
maantje:patch-2
Mar 7, 2019
Merged

ssddanbrown merged 1 commit into
BookStackApp:masterfrom
maantje:patch-2

Conversation

@maantje

@maantje maantje commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

At the moment the Dutch translation says Minimaal 5 tekens which means your password should be at least 5 characters long. But a 5 character long password is not allowed by the validator.

I think this was a translation error from the English one where it says Must be over 5 characters. To make the Dutch translation correct the Dutch translation should be changed to Minimaal 6 tekens.

/**
 * Get a validator for an incoming registration request.
 *
 * @param  array $data
 * @return \Illuminate\Contracts\Validation\Validator
 */
protected function validator(array $data)
{
    return Validator::make($data, [
        'name' => 'required|max:255',
        'email' => 'required|email|max:255|unique:users',
        'password' => 'required|min:6',
    ]);
}

…rule

At the moment the translation says ```Minimaal 5 tekens``` which means your password should be at least 5 characters long. But a 5 character long password is not allowed by the validator. 

I think this was a translation error from the English one where it says ```Must be over 5 characters```. To make the Dutch translation correct the Dutch translation should be changed to ```Minimaal 6 tekens```.

```
    /**
     * Get a validator for an incoming registration request.
     *
     * @PARAM  array $data
     * @return \Illuminate\Contracts\Validation\Validator
     */
    protected function validator(array $data)
    {
        return Validator::make($data, [
            'name' => 'required|max:255',
            'email' => 'required|email|max:255|unique:users',
            'password' => 'required|min:6',
        ]);
    }
```
@ssddanbrown ssddanbrown added this to the v0.25.2 milestone Mar 7, 2019
@ssddanbrown

Copy link
Copy Markdown
Member

Thanks for spotting this @maantje.
I will merge in now ready for the next patch release.

@ssddanbrown
ssddanbrown merged commit 579d98a into BookStackApp:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants