Skip to content

Fixes tooltip on the image manager. - #1238

Merged
ssddanbrown merged 1 commit into
masterfrom
fix-1186
Mar 8, 2019
Merged

ssddanbrown merged 1 commit into
masterfrom
fix-1186

Conversation

@Abijeet

@Abijeet Abijeet commented Jan 27, 2019

Copy link
Copy Markdown
Member

Fixes #1186

image

image

  1. I've added a message.
  2. The tooltip arrow now appears slightly off-center. I think that's an acceptable trade-off.

@Abijeet Abijeet self-assigned this Jan 27, 2019
@Abijeet
Abijeet requested a review from ssddanbrown January 27, 2019 14:17
@Abijeet Abijeet added this to the v0.25.2 milestone Jan 27, 2019

.image-manager-sidebar {
width: 300px;
margin-left: 1px;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was there. Adds a bit of gap which I think doesn't look very good.

@ssddanbrown
ssddanbrown merged commit 9dba9ca into master Mar 8, 2019
@ssddanbrown

Copy link
Copy Markdown
Member

Thanks @Abijeet, I agree with the removal of the random margin.

Now merged! It did look a little odd with the shifted arrow so I updated the arrow position a little.

@ssddanbrown
ssddanbrown deleted the fix-1186 branch September 6, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants