Add select account parameter for google authorization - #1063
Conversation
Useful for choosing an account if a default account is outside the scope of a G Suite organization.
ssddanbrown
left a comment
ssddanbrown
left a comment
There was a problem hiding this comment.
Thanks @justein230 for creating this pull request.
I'm not confident if forcing this functionality for all Google sign-in users is a good idea. I think many people may enjoy a one-click experience which, as far as I can see, this would remove.
|
@ssddanbrown I added an env switch for this called GOOGLE_SELECT_ACCOUNT, and I check if it is true before adding that parameter. Let me know if this is sufficient for this feature to be added. |
|
@ssddanbrown I made the requested changes, and can't figure out why the checks have failed. I tested in my development environment and the changes work as intended. Any ideas? |
|
@justein230 Looks good. The tests being broken was totally my fault. I'd left some broken bits in |
2 participants
Useful for choosing an account if a default account is outside the scope of a G Suite organization.