Skip to content

Seemingly incomplete German notifications #835

Description

@alex2702
  • BookStack Version: 0.21.0 (has happened for a while though)
  • PHP Version: 7.2
Expected Behavior

After certain actions, e.g. creating a page, notifications are shown. In English, this may read something like Page Successfully Created.

Current Behavior

In the German language files (resources/lang/de/*), these notifications are the equivalent to has successfully created page. Not only should there be a username in front of the text, it also seems like there should be the page name at the end of it. However, no other language (that I speak) shows this format. Instead, other translations simply state that the page has been created, no username, no page name. While I would appreciate the more informative approach that the German translator has suggested, it just doesn't look like it is supported at this point?

Steps to Reproduce

Any action like creating a page, saving an existing one, making comments etc will show the behavior.
It seems like it was introduced in commit 0d6a6b5b.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions