Seems to be causing issues serving video in chromium based browsers.
"Rare Candy" on discord helped find the cause, which is this line:
|
} elseif ($end - $start < $this->fileSize - 1) { |
Due to this, we're not sending partial/range responses to full range requests, which kinda makes sense in a way, but it seems like browsers still want/need that full range response (even for a full response) to work as desired.
Can be solved by removing the -1, but might want to check if that condition is redundant or not.
Needs test to cover.
Discord thread: https://discord.com/channels/578552496637739008/1247823044869886006
Seems to be causing issues serving video in chromium based browsers.
"Rare Candy" on discord helped find the cause, which is this line:
BookStack/app/Http/RangeSupportedStream.php
Line 95 in 91d8d6e
Due to this, we're not sending partial/range responses to full range requests, which kinda makes sense in a way, but it seems like browsers still want/need that full range response (even for a full response) to work as desired.
Can be solved by removing the
-1, but might want to check if that condition is redundant or not.Needs test to cover.
Discord thread: https://discord.com/channels/578552496637739008/1247823044869886006