Skip to content

[Bug Report]: Webhook fails for specific recycle bin operations #3154

Description

@ssddanbrown

Describe the Bug

Recycle bin item restore/destroy operations lead to the below error when a webhook is active using the recycle_bin_restore/destroy operations.

Too few arguments to function BookStack\Entities\Models\Deletion::getUrl(), 0 passed in /home/dan/web/bookstack/app/Actions/DispatchWebhookJob.php on line 123 and exactly 1 expected

Is due to the getUrl on the Deletion model requiring a param. Needs to have a default or the usage of URL within webhook data needs to be more targeted.


Reported by abe on discord.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions