Skip to content

Perform a review pass of the permission service #2633

Description

@ssddanbrown

More of a reminder for me:

Review the permission service class.

  • Move phpdoc to types.
  • Remove instances if ->isA()
  • entityCache['chapter'] does not appear to be actually used. It does appear to use it but does potentially overly wipe it when processing many items, May not matter depending on entries to readyEntityCache

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions