Skip to content

fixed thrown TypeErrors on mac, while scrolling over the top edge - #196

Merged
timruffles merged 1 commit into
BonsaiDen:masterfrom
sweaf:master
Nov 6, 2013
Merged

timruffles merged 1 commit into
BonsaiDen:masterfrom
sweaf:master

Conversation

@sweaf

@sweaf sweaf commented Oct 30, 2013

Copy link
Copy Markdown
Contributor

Due to the mac specific possibility to scroll above the top viewport edges (this nice viewport pull effect), you get some negative scroll and offset values. This causes a call of this.names[-1] which throws a TypeError. So we just test for a positive scroll value to prevent this.

Due to the mac specific possibility to scroll above the top viewport edges (this nice viewport pull effect), you get some negative scroll and offset values. This causes a call of this.names[-1] which throws a TypeError. So we just test for a positive scroll value to prevent this.
@timruffles

Copy link
Copy Markdown
Collaborator

Thanks!

timruffles added a commit that referenced this pull request Nov 6, 2013
fixed thrown TypeErrors on mac, while scrolling over the top edge
@timruffles
timruffles merged commit bdf34bf into BonsaiDen:master Nov 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants