Hanson1 - menubar, menu, table UI #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 17, 2018 23:15
- uses getBoundingClientRect() to replace actual icon image by painted background on labels (not yet buttons, but that should be no issue) - aligns icon and text properly (though untested for horizontalTextPosition=CENTER verticalAlignment=TOP/BOTTOM) - redesigned menu item rendering
shift key on mouse drag not recorded in event extended modifiers, resulting in LightweightDispatcher not considering it a "mouse grab"
data model is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menubar, menu, table upgrades; better table performance when underlying
data model is changed.