fixup javascript patch for switch to native strings in java.text.SimpleDateFormat #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@BobHanson - you probably just want the patch to SImpleDate - I think the swingjs-runtime rebuild failed so that part of the commit is bunk, but I've verified by manually patching the runtime that this error is resolved. |
BobHanson
approved these changes
Jul 20, 2021
Owner
|
Actually, it was more involved than that. java2script was not properly
handling the default local time zone and daylight savings time. So that is
pushed through to master.
…On Mon, Jul 19, 2021 at 11:03 AM Jim Procter ***@***.***> wrote:
squashes a 'length is not a function' javascript runtime error for classes
using java.text.SimpleDateFormat
------------------------------
You can view, comment on, or merge this pull request online at:
#216
Commit Summary
- fixup javascript patch for switch to native strings in
java.text.SimpleDateFormat
File Changes
- *M* sources/net.sf.j2s.java.core/dist/SwingJS-site.zip
<https://github.com/BobHanson/java2script/pull/216/files#diff-0e715b090b64baa15361adac31af5cb603e263e9048eeb93260cc4b8c1ba9873>
(0)
- *M* sources/net.sf.j2s.java.core/src/java/text/SimpleDateFormat.java
<https://github.com/BobHanson/java2script/pull/216/files#diff-a5a450cb1347678f95a869724b82516bc7dffec28b4ad6aef0243100c81c303d>
(2)
Patch Links:
- https://github.com/BobHanson/java2script/pull/216.patch
- https://github.com/BobHanson/java2script/pull/216.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#216>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEHNCW5VIXYFPRZCL2YJLN3TYREERANCNFSM5AT77ZTA>
.
--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr
If nature does not answer first what we want,
it is better to take what answer we get.
-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900
*We stand on the homelands of the Wahpekute Band of the Dakota Nation. We
honor with gratitude the people who have stewarded the land throughout the
generations and their ongoing contributions to this region. We acknowledge
the ongoing injustices that we have committed against the Dakota Nation,
and we wish to interrupt this legacy, beginning with acts of healing and
honest storytelling about this place.*
|
Owner
|
Thanks:) it was good to remind myself how to patch swingjs but I clearly need more practice!!
J.
…________________________________
From: Robert Hanson ***@***.***>
Sent: 20 July 2021 22:45
To: BobHanson/java2script ***@***.***>
Cc: BobHanson/java2script ***@***.***>; Jim Procter ***@***.***>
Subject: Re: [BobHanson/java2script] fixup javascript patch for switch to native strings in java.text.SimpleDateFormat (#216)
Actually, it was more involved than that. java2script was not properly handling the default local time zone and daylight savings time. So that is pushed through to master.
On Mon, Jul 19, 2021 at 11:03 AM Jim Procter ***@***.******@***.***>> wrote:
squashes a 'length is not a function' javascript runtime error for classes using java.text.SimpleDateFormat
________________________________
You can view, comment on, or merge this pull request online at:
#216
Commit Summary
* fixup javascript patch for switch to native strings in java.text.SimpleDateFormat
File Changes
* M sources/net.sf.j2s.java.core/dist/SwingJS-site.zip<https://github.com/BobHanson/java2script/pull/216/files#diff-0e715b090b64baa15361adac31af5cb603e263e9048eeb93260cc4b8c1ba9873> (0)
* M sources/net.sf.j2s.java.core/src/java/text/SimpleDateFormat.java<https://github.com/BobHanson/java2script/pull/216/files#diff-a5a450cb1347678f95a869724b82516bc7dffec28b4ad6aef0243100c81c303d> (2)
Patch Links:
* https://github.com/BobHanson/java2script/pull/216.patch
* https://github.com/BobHanson/java2script/pull/216.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#216>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEHNCW5VIXYFPRZCL2YJLN3TYREERANCNFSM5AT77ZTA>.
--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr
If nature does not answer first what we want,
it is better to take what answer we get.
-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900
We stand on the homelands of the Wahpekute Band of the Dakota Nation. We honor with gratitude the people who have stewarded the land throughout the generations and their ongoing contributions to this region. We acknowledge the ongoing injustices that we have committed against the Dakota Nation, and we wish to interrupt this legacy, beginning with acts of healing and honest storytelling about this place.
The University of Dundee is a registered Scottish Charity, No: SC015096
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squashes a 'length is not a function' javascript runtime error for classes using java.text.SimpleDateFormat