Add ability to set .j2s config filepath/name by setting property … #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sf.j2s.core.j2sFileName when launching Eclipse
Owner
|
This will not work in general. It's scope is for all projects in a
workspace, but each project has its own .j2s needs.
What is the critical need here?
…On Sat, Dec 19, 2020 at 6:01 PM benzoid ***@***.***> wrote:
… "net.sf.j2s.core.j2sFileName" when launching Eclipse
e.g.
eclipse --launcher.appendVmargs -vmargs
-Dnet.sf.j2s.core.j2sFileName=build/jalviewjs/eclipse/j2sConfig
------------------------------
You can view, comment on, or merge this pull request online at:
#199
Commit Summary
- Add ability to set .j2s config filepath/name by setting property
net.sf.j2s.core.j2sFileName when launching Eclipse
File Changes
- *M*
sources/net.sf.j2s.core/src/net/sf/j2s/core/Java2ScriptCompiler.java
<https://github.com/BobHanson/java2script/pull/199/files#diff-782da21530716a76933d949f6555557c4ffed9409ab0915696a886b3c50a9dcd>
(2)
Patch Links:
- https://github.com/BobHanson/java2script/pull/199.patch
- https://github.com/BobHanson/java2script/pull/199.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#199>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEHNCW2WIDDN7FIG4WCMM43SVU5DXANCNFSM4VCU7S5A>
.
--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr
If nature does not answer first what we want,
it is better to take what answer we get.
-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900
*We stand on the homelands of the Wahpekute Band of the Dakota Nation. We
honor with gratitude the people who have stewarded the land throughout the
generations and their ongoing contributions to this region. We acknowledge
the ongoing injustices that we have committed against the Dakota Nation,
and we wish to interrupt this legacy, beginning with acts of healing and
honest storytelling about this place.*
|
Author
|
The use case is for a headless transpilation run of eclipse, which I think only operates on one project. The headless run in our case requires a different j2s configuration than the general Eclipse development using j2s. |
…an alternative j2s file
Author
|
Changes made so that you can set in (the usual) .j2s file: j2s.config.altfileproperty=my.property.name and the plugin will look for System.getProperty("my.property.name") and if it's there and is a file that exists will use that in preference to the .j2s file. I've only done some brief testing but it appears to work! |
Owner
|
pushed to BobHanson/java2script/master
#201
Has a few changes.
-- allows iterative chaining of .j2s file references
-- more streamlined code
-- adds j2s.config.altfileproperty to the .j2s template
-- untested on my machine
Let me know how it goes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… "net.sf.j2s.core.j2sFileName" when launching Eclipse
e.g.
eclipse --launcher.appendVmargs -vmargs -Dnet.sf.j2s.core.j2sFileName=build/jalviewjs/eclipse/j2sConfig