Skip to content

Executors.submit(Runnable) not returning a Future #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BobHanson merged 1 commit into from
Nov 27, 2020
Merged

Executors.submit(Runnable) not returning a Future #181

BobHanson merged 1 commit into from
Nov 27, 2020

Conversation

@BobHanson
Copy link
Owner

@BobHanson BobHanson commented Nov 27, 2020

A quick fix is to remove the

task.run();
return;

from Executors.submit$Runnable()

This works in test.Test_Future.java (hansonr1 branch):

	 ExecutorService dialogExecutor = Executors.newSingleThreadExecutor();
	 Future<?> f = dialogExecutor.submit(() -> {
		System.out.println("dialog runnable 1");
	});
	 dialogExecutor.submit(() -> {
		System.out.println("dialog runnable 2");
	});
	 dialogExecutor.submit(() -> {
		System.out.println("dialog runnable 3");
		System.out.println(f.toString() + f.isDone());
	});
	System.out.println("CompletionStage started");
	System.out.println(f.toString() + f.isDone());

delivering:

CompletionStage started
[java.util.concurrent.FutureTask object]false
dialog runnable 1
dialog runnable 2
dialog runnable 3
[java.util.concurrent.FutureTask object]true

@BobHanson BobHanson merged commit 0f99b47 into master Nov 27, 2020
warownia1 pushed a commit to warownia1/java2script that referenced this pull request Sep 13, 2022
@BobHanson
Merge pull request BobHanson#181 from BobHanson/master
0625069 
upgrade for Jmol and SimpleHTTPClient (Jalview)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BobHanson