* Fixed python fatal error when opening popups

cztomczak · cztomczak · commit 7d5f7d639d8a · 2013-01-09T15:18:15.000-08:00
(Issue 45 &amp; Issue 46)
diff --git a/cefpython/browser.pyx b/cefpython/browser.pyx
@@ -70,9 +70,9 @@ cdef PyBrowser GetPyBrowser(CefRefPtr[CefBrowser] cefBrowser):
                     pyBrowser.SetClientCallbacksDict(clientCallbacks)
                 IF CEF_VERSION == 1:
                     javascriptBindings = tempPyBrowser.GetJavascriptBindings()
-                    if javascriptBindings.GetBindToPopups():
-                        pyBrowser.SetJavascriptBindings(javascriptBindings)
-
+                    if javascriptBindings:
+                        if javascriptBindings.GetBindToPopups():
+                            pyBrowser.SetJavascriptBindings(javascriptBindings)
     return pyBrowser
 
 cpdef PyBrowser GetBrowserByWindowHandle(int windowHandle):
@@ -128,7 +128,8 @@ cdef class PyBrowser:
             if <void*>cefBrowserHost != NULL and cefBrowserHost.get():
                 return cefBrowserHost
             raise Exception("PyBrowser.GetCefBrowserHost() failed: this "
-                            "method can only be called in the browser process.")
+                            "method can only be called in the browser "
+                            "process.")
 
     def __init__(self):
         self.clientCallbacks = {}
diff --git a/cefpython/cef1/windows/binaries/cefsimple.html b/cefpython/cef1/windows/binaries/cefsimple.html
@@ -20,6 +20,11 @@ <h3>User agent</h3>
 
     <script>document.write(navigator.userAgent)</script>
 
+<h3>Popup</h3>
+
+<a href="javascript:window.open('cefsimple.html')">
+	window.open('cefsimple.html')</a>
+
 <br><br><br><br><br><br><br><br><br><br><br>
 <br><br><br><br><br><br><br><br><br><br><br>
 <br><br><br><br><br><br><br><br><br><br><br>
diff --git a/cefpython/cef1/windows/binaries/cefsimple.py b/cefpython/cef1/windows/binaries/cefsimple.py
@@ -57,6 +57,7 @@ def ExceptHook(type, value, traceObject):
 
 def CefSimple():
     sys.excepthook = ExceptHook
+    cefpython.g_debug = True
     cefpython.Initialize()
     wndproc = {
         win32con.WM_CLOSE: CloseWindow,
