Addded comments in the wxpython.py example on Windows, about the

cztomczak · cztomczak · commit 0c1edf032307 · 2015-01-22T17:58:37.000+01:00
implication of creating the popup window of our own. The popup window
and parent window will not be able to script each other. There will
be no "window.opener" property available in the popup window.
diff --git a/cefpython/cef3/windows/binaries_32bit/wxpython.html b/cefpython/cef3/windows/binaries_32bit/wxpython.html
@@ -99,10 +99,15 @@ <h2>Popups</h2>
     </li>
 </ol>
 
-There are problems with keyboard when allow CEF to create popup
-windows internally. To create popup window explicitilly, the
-LifespanHandler::OnBeforePopup callback was implemented. See its
-source:
+There are problems with keyboard in wxPython when popup windows are created
+by CEF (<a href="https://code.google.com/p/cefpython/issues/detail?id=80">
+Issue 80</a>). To create the popup window of our own, the
+LifespanHandler::OnBeforePopup callback was implemented. Note that this has
+its implications, the popup window and parent window will not be able to
+script each other. There will be no "window.opener" property available
+in the popup window.
+
+See its source:
 
 <script>ShowSource("OnBeforePopup");</script>
 <script>ShowSource("_CreatePopup");</script>
diff --git a/cefpython/cef3/windows/binaries_32bit/wxpython.py b/cefpython/cef3/windows/binaries_32bit/wxpython.py
@@ -651,14 +651,22 @@ def OnBeforePopup(self, browser, frame, targetUrl, targetFrameName,
         # is created using "window.open" or "target=blank". This issue
         # occurs only in wxPython. PyGTK or PyQt do not require this fix.
         # The solution is to create window explicitilly, and not depend
-        # on CEF to create window internally.
+        # on CEF to create window internally. See Issue 80 for details:
+        # https://code.google.com/p/cefpython/issues/detail?id=80
+
         # If you set allowPopups=True then CEF will create popup window.
         # The wx.Frame cannot be created here, as this callback is
         # executed on the IO thread. Window should be created on the UI
         # thread. One solution is to call cefpython.CreateBrowser()
         # which runs asynchronously and can be called on any thread.
         # The other solution is to post a task on the UI thread, so
         # that cefpython.CreateBrowserSync() can be used.
+
+        # Note that if you return True and create the popup window yourself,
+        # then the popup window and parent window will not be able to script
+        # each other. There will be no "window.opener" property available
+        # in the popup window.
+
         cefpython.PostTask(cefpython.TID_UI, self._CreatePopup, targetUrl)
 
         allowPopups = False
diff --git a/cefpython/cef3/windows/binaries_64bit/wxpython.html b/cefpython/cef3/windows/binaries_64bit/wxpython.html
@@ -99,10 +99,15 @@ <h2>Popups</h2>
     </li>
 </ol>
 
-There are problems with keyboard when allow CEF to create popup
-windows internally. To create popup window explicitilly, the
-LifespanHandler::OnBeforePopup callback was implemented. See its
-source:
+There are problems with keyboard in wxPython when popup windows are created
+by CEF (<a href="https://code.google.com/p/cefpython/issues/detail?id=80">
+Issue 80</a>). To create the popup window of our own, the
+LifespanHandler::OnBeforePopup callback was implemented. Note that this has
+its implications, the popup window and parent window will not be able to
+script each other. There will be no "window.opener" property available
+in the popup window.
+
+See its source:
 
 <script>ShowSource("OnBeforePopup");</script>
 <script>ShowSource("_CreatePopup");</script>
diff --git a/cefpython/cef3/windows/binaries_64bit/wxpython.py b/cefpython/cef3/windows/binaries_64bit/wxpython.py
@@ -651,14 +651,22 @@ def OnBeforePopup(self, browser, frame, targetUrl, targetFrameName,
         # is created using "window.open" or "target=blank". This issue
         # occurs only in wxPython. PyGTK or PyQt do not require this fix.
         # The solution is to create window explicitilly, and not depend
-        # on CEF to create window internally.
+        # on CEF to create window internally. See Issue 80 for details:
+        # https://code.google.com/p/cefpython/issues/detail?id=80
+
         # If you set allowPopups=True then CEF will create popup window.
         # The wx.Frame cannot be created here, as this callback is
         # executed on the IO thread. Window should be created on the UI
         # thread. One solution is to call cefpython.CreateBrowser()
         # which runs asynchronously and can be called on any thread.
         # The other solution is to post a task on the UI thread, so
         # that cefpython.CreateBrowserSync() can be used.
+
+        # Note that if you return True and create the popup window yourself,
+        # then the popup window and parent window will not be able to script
+        # each other. There will be no "window.opener" property available
+        # in the popup window.
+
         cefpython.PostTask(cefpython.TID_UI, self._CreatePopup, targetUrl)
 
         allowPopups = False
