Skip to content

Add ghosts properties to inspection#93

Merged
mtinning merged 4 commits intomasterfrom
ghost-inspection
Feb 15, 2019
Merged

Add ghosts properties to inspection#93
mtinning merged 4 commits intomasterfrom
ghost-inspection

Conversation

@phil-brad
Copy link
Member

Ghost properties were not included in inspection of the specification at all. It's debatable the best way to do this in terms of whether to consider them "concrete" properties once the spec has been parsed. I have chosen not to and add ghost properties at the leaf only (given that they are passed all the way through the tree, including them at every node would be repetition). So:

"children": [
  {
    "name": "alpha",
    "value": "tadpole",
    "ghosts": {"casper": 1.0}
  }
]

@phil-brad phil-brad added the bug Something isn't working label Feb 6, 2019
mtinning
mtinning previously approved these changes Feb 7, 2019
Copy link
Member

@mtinning mtinning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - I've just added the ghost inspection to prettyspec too

@phil-brad
Copy link
Member Author

can you approve?

Copy link
Member

@mtinning mtinning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@mtinning mtinning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mtinning mtinning merged commit f10bea7 into master Feb 15, 2019
@phil-brad phil-brad deleted the ghost-inspection branch November 22, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants