Merged
Conversation
…tors Ensuring that subsequent nodes to evaluators are made children of evaluators (fixes #106)
mtinning
previously approved these changes
Mar 17, 2020
Member
mtinning
left a comment
mtinning
left a comment
There was a problem hiding this comment.
Minor pointer if you want it, otherwise good!
spawn/specification/evaluators.py
Outdated
| return evaluate(arg, **kwargs) if isinstance(arg, ValueProxy) else arg | ||
| except ParameterNotFoundError as ex: | ||
| evaluator_name = self._name or type(self).__name__ | ||
| raise EvaluatorParameterNotFoundError(ex.parameter_name, evaluator_name) |
Member
There was a problem hiding this comment.
You can use the syntax raise new_exception from original_exception - this makes things a bit clearer in the trace
mtinning
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added error handling to catch case where evaluator does not recognise parameter argument