Merged
Conversation
phil-brad
commented
Oct 31, 2019
| from ..simulation_inputs import JsonSimulationInput | ||
|
|
||
|
|
||
| def create_spawner(task_exe, working_dir, base_file, runner_type): |
Member
Author
There was a problem hiding this comment.
I haven't written a unit test for this. I don't know if you have any recommended ways of testing it
Member
There was a problem hiding this comment.
For a unit test, you could:
- patch
configuration.get_config()with a mock object and check that the configration parameters are set correctly - check that the parameters you pass from the input file are accessible from the returned spawner
phil-brad
commented
Oct 31, 2019
mtinning
requested changes
Nov 8, 2019
| from ..simulation_inputs import JsonSimulationInput | ||
|
|
||
|
|
||
| def create_spawner(task_exe, working_dir, base_file, runner_type): |
Member
There was a problem hiding this comment.
For a unit test, you could:
- patch
configuration.get_config()with a mock object and check that the configration parameters are set correctly - check that the parameters you pass from the input file are accessible from the returned spawner
Member
Author
|
Test for JSON plugin added |
mtinning
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an inbuilt JSON plugin which uses:
SingleInputFileSpawnerwhich is a simple spawner, spawning tasks that take one input file as argument. Sets attributes through aSimulationInputobjectJsonSimulationInputobject which sets items into a dictionary and writes to a JSON file.The JSON plugin creates a
SingleInputFileSpawnerwhich uses aJsonSimulationInput.Change to
SimulationTaskso that in case the_exe_pathis empty, simulations are not run (but a spawner will still do preceding actions such as writing input files.