Reformat code with black#13
Closed
XVilka wants to merge 3 commits intoBinaryAnalysisPlatform:masterfrom
Closed
Conversation
Contributor
Author
ivg
reviewed
Sep 21, 2020
| class MSR(Special) : pass | ||
| class PLDi12(Special) : pass | ||
| class SVC(Special) : pass | ||
|
|
Member
There was a problem hiding this comment.
This renders the module totally unreadable. The whole idea is that you can quickly see different variants of the ADT.
ivg
reviewed
Sep 21, 2020
| self.msg = self.bap.get_resource(self.ident) | ||
| if not self._name in self.msg: | ||
| if "error" in msg: | ||
| if "error" in self.msg: |
Member
There was a problem hiding this comment.
it looks like that there was a bug here
ivg
requested changes
Sep 21, 2020
Member
ivg
left a comment
ivg
left a comment
There was a problem hiding this comment.
I am definitely against the black formatting, it destroys code readability. There is, however, a real bug fix (the second commit) which we will happily accept.
Thanks!
Merged
Contributor
Author
|
Closing in favor or just fixes then: #15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Black is the uncompromising Python code formatter. By using it, you agree to cede control over minutiae of hand-formatting. In return, Black gives you speed, determinism, and freedom from pycodestyle nagging about formatting. You will save time and mental energy for more important matters.
Blackened code looks the same regardless of the project you're reading. Formatting becomes transparent after a while and you can focus on the content instead.
Black makes code review faster by producing the smallest diffs possible.