chore(admin-ui): regenerate static export with trailingSlash: true#28112
Open
mateo-berri wants to merge 1 commit into
Open
chore(admin-ui): regenerate static export with trailingSlash: true#28112mateo-berri wants to merge 1 commit into
mateo-berri wants to merge 1 commit into
Conversation
Rebuilds litellm/proxy/_experimental/out/ from ui/litellm-dashboard with `trailingSlash: true` enabled in next.config.mjs. Next.js now emits every route as <dir>/index.html (e.g. mcp/oauth/callback/index.html) instead of <dir>.html with a sibling metadata-only directory, which fixes the 404 on extensionless URLs served through FastAPI's StaticFiles(html=True) mount. This is the build artifact half of the fix; the config change, Dockerfile cleanup, and regression test live in the follow-up source PR that stacks on top of this branch.
Contributor
|
Too many files changed for review. ( |
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Stacked under #28106. Split out of that PR so the source change and regression test can be reviewed without 800+ build-artifact diffs in the way.
Linear ticket
N/A
Pre-Submission checklist
make test-unit@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewCI (LiteLLM team)
Screenshots / Proof of Fix
The proof of fix lives in the source PR #28106; this PR is purely the rebuilt
litellm/proxy/_experimental/out/artifact that the source PR depends on. Once both land, the curl and browser flow shown in #28106 produces the same result against the deployed image.The artifact was regenerated by running
npm run buildinsideui/litellm-dashboard(withtrailingSlash: trueapplied locally per #28106's diff) and copying./out/.intolitellm/proxy/_experimental/out/. Every previously top-level<name>.htmlis now under<name>/index.html; the only top-level HTML files left areindex.htmland404.html, which Next.js requires by those exact names.Type
Infrastructure
Changes
Regenerated
litellm/proxy/_experimental/out/from the dashboard build withtrailingSlash: trueso every nested route lives at<dir>/index.html. No source code changes in this PR; the config change, Dockerfile cleanup, and regression test are in the stacked source PR.Note
Medium Risk
Large build-artifact-only update that changes the on-disk routing shape (moves pages to
*/index.html) and revs hashed asset filenames/build IDs; main risk is broken dashboard routing or missing assets at runtime.Overview
Regenerates the dashboard static export under
litellm/proxy/_experimental/out/with trailing-slash output, so nested routes are emitted as directories containingindex.html(e.g., adds404/index.html) while keeping required top-level files like404.html.This refresh also updates Next.js export metadata (
__next.*.txt), build IDs, and hashed_next/staticasset filenames/chunks to match the new build output.Reviewed by Cursor Bugbot for commit 8757b86. Bugbot is set up for automated code reviews on this repo. Configure here.