Skip to content

Litellm hotfix azure ai gpt 5.4 main#28104

Open
shivamrawat1 wants to merge 3 commits into
mainfrom
litellm_hotfix_azure_ai_gpt-5.4_main
Open

Litellm hotfix azure ai gpt 5.4 main#28104
shivamrawat1 wants to merge 3 commits into
mainfrom
litellm_hotfix_azure_ai_gpt-5.4_main

Conversation

@shivamrawat1
Copy link
Copy Markdown
Collaborator

gpt-5.4 azure_ai for foundry

shivamrawat1 and others added 3 commits May 16, 2026 18:47
Register azure_ai GPT-5.4 variants with pricing, context limits from
Foundry catalog, and capability flags for cost routing and tooling.

Co-authored-by: Cursor <cursoragent@cursor.com>
…data

Add supports_web_search for base GPT-5.4 aliases, priority-tier Pro rates,
and mini/nano above-272k plus priority pricing for correct spend math.

Co-authored-by: Cursor <cursoragent@cursor.com>
…ckup row

Mirror supports_web_search for azure_ai/gpt-5.4-2026-03-05 in the backup
catalog so it matches model_prices_and_context_window.json.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented May 17, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing litellm_hotfix_azure_ai_gpt-5.4_main (907d533) with main (e58a561)

Open in CodSpeed

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 17, 2026

Greptile Summary

This PR adds eight new azure_ai model entries to both the primary and backup model pricing JSON files: gpt-5.4, gpt-5.4-pro, gpt-5.4-mini, and gpt-5.4-nano, each accompanied by a dated snapshot alias (e.g. gpt-5.4-2026-03-05).

  • Pricing arithmetic is internally consistent across all tiers: the cache-read discount is uniformly 10% of the corresponding input cost, the above-272k tier doubles the base rate, and the priority tier also doubles the base rate.
  • azure_ai/gpt-5.4-pro (and its alias) sets \"mode\": \"responses\" and omits /v1/chat/completions from supported_endpoints, making it a responses-API-only model — a notable divergence from the other three family members that all support chat completions.
  • Both JSON files are kept in sync with identical additions.

Confidence Score: 4/5

Safe to merge with a quick confirmation that gpt-5.4-pro is intentionally responses-API-only and that the pricing figures match the Azure Foundry catalog.

The change is purely additive JSON config — no runtime logic is touched. The pricing math checks out internally, and both files are kept in sync. The two open questions are whether the gpt-5.4-pro chat-completions omission is intentional, and whether the pricing figures have been cross-checked against the official Azure catalog, neither of which can be verified from the PR description alone.

The azure_ai/gpt-5.4-pro entry in both JSON files deserves a second look to confirm the responses-only mode and pricing are accurate per the Azure Foundry listing.

Important Files Changed

Filename Overview
model_prices_and_context_window.json Adds 8 new azure_ai/gpt-5.4 model variants (base, pro, mini, nano — each with a dated snapshot alias); pricing math is internally consistent; gpt-5.4-pro is responses-mode only (no /v1/chat/completions), which diverges from the other family members and may be intentional but is unverified in the PR description.
litellm/model_prices_and_context_window_backup.json Backup file updated in lock-step with the primary; identical entries and the same internal pricing consistency; same gpt-5.4-pro responses-only concern applies.

Comments Outside Diff (2)

  1. model_prices_and_context_window.json, line 488 (link)

    P2 gpt-5.4-pro missing /v1/chat/completions endpoint

    azure_ai/gpt-5.4-pro (and its dated variant) set "mode": "responses" and list only /v1/batch and /v1/responses as supported_endpoints, omitting /v1/chat/completions. The other gpt-5.4 family members all include chat completions. If this model actually supports chat completions on Azure Foundry, this entry will silently mis-represent its capabilities and may confuse users who try the standard chat path. If the omission is intentional (responses-API-only model), a brief comment or source link clarifying that would help reviewers verify the pricing data.

  2. model_prices_and_context_window.json, line 394 (link)

    P2 PR description lacks evidence of what was fixed

    The PR title says "hotfix" but the description contains only "gpt-5.4 azure_ai for foundry" with no reference to a GitHub issue, no prior bug report, and no test output confirming the entries are correct. Per the team's review standard, PRs claiming to fix something should include verifiable evidence (e.g., a link to the Azure pricing page, a test run, or an issue number). Without a source cross-reference it's hard to confirm that the pricing values and capability flags are accurate.

    Rule Used: What: Ensure that any PR claiming to fix an issue ... (source)

Reviews (1): Last reviewed commit: "fix(model_catalog): sync web_search flag..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant