Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: BerkeleyLibrary/framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: BerkeleyLibrary/framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ADA-269-pass-admin
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 24 files changed
  • 1 contributor

Commits on Jun 26, 2025

  1. Overhaul Stack Pass Administrator pages

    * Move user management to its own controller and views.
    * Allow editing of user names.
    awilfox committed Jun 26, 2025
    Configuration menu
    Copy the full SHA
    61f4b17 View commit details
    Browse the repository at this point in the history
  2. Fixes for Stack Pass Admin overhaul

    * Ensure errors are displayed correctly when form submission fails.
    * Validate that the lcasid is always a number (don't allow invalid).
    * Appease Rubocop.
    awilfox committed Jun 26, 2025
    Configuration menu
    Copy the full SHA
    b76b5bb View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2025

  1. Accessibility work on Stack Pass admin section

    CSS:
      - Vertically align sortable columns in the middle.
      - Add styling for sortable column buttons, based in part on the W3C
        ARIA APG recommendation / design pattern[1] for sortable columns.
      - Add more padding between column header and sort arrow.
    
    Application Helper:
      - Have the `sortable` helper create the entire <TH/> element.
      - Set the aria-sort property on the <TH/> element.
      - Space between 'Log Out' to fix weird Windows Narrator glitch.
    
    Stack request base model:
      - Add a method for the human-friendly status of the request.
        This helps DRY the views.
    
    Reference card / stack pass request lists:
      - Fix ups, accessibility best practices, etc.
    
    Proxy Borrower admin views:
      - Fix up for `sortable` helper change.
    
    Locales:
      - Add page titles for the pages missing them.
    
    Closes: ADA-270, ADA-271, ADA-272, ADA-273.
    
    [1]: https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/
    awilfox committed Jul 3, 2025
    Configuration menu
    Copy the full SHA
    abff685 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7124f5e View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2025

  1. Rework Stack Pass administrator name handling

    Instead of having the name edited by site admins, we update it on the
    user's log in action from CAS.  This ensures it is always up to date.
    
    This additionally adds a column to the database for the FrameworkUser
    ID of who processed the request, so that the updates cascade.
    
    TBD: Migration logic should be added that will search the database for
    existing names and replace them with the FrameworkUser ID, so that
    updates cascade for these users as well.
    awilfox committed Oct 20, 2025
    Configuration menu
    Copy the full SHA
    a47c2d9 View commit details
    Browse the repository at this point in the history
Loading