Skip to content

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Jun 6, 2025

PR Type

enhancement


Description

  • Add Python 3.13.3 support with configuration and scripts

    • Introduce new configuration and batch files for Python 3.13.3
    • Add wheel installation script and properties for pywin32
  • Update release and build properties for new version

    • Register Python 3.13.3 in releases and update bundle release version

Changes walkthrough 📝

Relevant files
Enhancement
python.bat
Add Python 3.13.3 launcher batch script                                   

bin/python3.13.3/bin/python.bat

  • Add batch script to launch Python 3.13.3 with environment setup
  • Ensures backward compatibility for command-line users
  • +6/-0     
    install.bat
    Add pywin32 wheel installation script for 3.13.3                 

    bin/python3.13.3/wheel/install.bat

  • Add batch script to install pywin32 wheel for Python 3.13.3
  • Sets up environment before running pip install
  • +5/-0     
    bearsampp.conf
    Add configuration for Python 3.13.3 bundle                             

    bin/python3.13.3/bearsampp.conf

  • Add configuration file for Python 3.13.3 integration
  • Specifies executables and release version placeholder
  • +6/-0     
    wheel.properties
    Add wheel properties for Python 3.13.3                                     

    bin/python3.13.3/wheel/wheel.properties

    • Add wheel properties file pointing to pywin32 wheel for 3.13.3
    +1/-0     
    Configuration changes
    build.properties
    Update bundle release version in build properties               

    build.properties

    • Update bundle release version to 2025.6.6
    +1/-1     
    releases.properties
    Add Python 3.13.3 to releases list                                             

    releases.properties

    • Register Python 3.13.3 release with download URL
    +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Hardcoded Wheel Version

    The script uses a hardcoded wheel filename (pywin32-310-cp313-cp313-win_amd64.whl) which appears to mix version numbers (310 in the filename but for Python 3.13). This might cause installation issues if the wheel naming convention is incorrect.

    "%WINPYDIR%\Scripts\pip.exe" install pywin32-310-cp313-cp313-win_amd64.whl
    
    Version Mismatch

    The wheel URL contains "pywin32-310-cp313-cp313-win_amd64.whl" which suggests a potential version mismatch (310 vs 313). Verify that this is the correct wheel package for Python 3.13.3.

    wheel = https://github.com/Bearsampp/modules-untouched/releases/download/python-2025.6.6/pywin32-310-cp313-cp313-win_amd64.whl

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix wheel version mismatch

    The wheel filename contains "310" which indicates Python 3.10 compatibility, but
    is being installed for Python 3.13.3. This mismatch could cause installation
    failures or runtime errors. Use a wheel specifically built for Python 3.13.

    bin/python3.13.3/wheel/install.bat [1-4]

     @echo off
     set WINPYSCRIPTSDIR=%~dp0..\scripts
     call "%WINPYSCRIPTSDIR%\env.bat"
    -"%WINPYDIR%\Scripts\pip.exe" install pywin32-310-cp313-cp313-win_amd64.whl
    +"%WINPYDIR%\Scripts\pip.exe" install pywin32-313-cp313-cp313-win_amd64.whl
    • Apply / Chat
    Suggestion importance[1-10]: 7

    __

    Why: The suggestion identifies a potential version mismatch in the wheel filename that could cause installation issues. However, the "310" might refer to the pywin32 package version rather than Python version, making this suggestion possibly incorrect.

    Medium
    Fix wheel URL version

    The URL references a wheel with "310" in the filename which indicates Python
    3.10 compatibility, but is being used for Python 3.13.3. This version mismatch
    could cause installation failures.

    bin/python3.13.3/wheel/wheel.properties [1]

    -wheel = https://github.com/Bearsampp/modules-untouched/releases/download/python-2025.6.6/pywin32-310-cp313-cp313-win_amd64.whl
    +wheel = https://github.com/Bearsampp/modules-untouched/releases/download/python-2025.6.6/pywin32-313-cp313-cp313-win_amd64.whl
    • Apply / Chat
    Suggestion importance[1-10]: 7

    __

    Why: Similar to the first suggestion, this identifies the same potential version mismatch in the wheel URL. The concern is valid but may be based on incorrect interpretation of the wheel naming convention.

    Medium
    • More

    @jwaisner
    Copy link
    Contributor

    @N6REJ , looks like the wheel is for 3.10 instead of 3.13

    @N6REJ
    Copy link
    Contributor Author

    N6REJ commented Jul 2, 2025

    The wheel is correct. It's a false positive due to python itself

    Why: The suggestion identifies a potential version mismatch in the wheel filename that could cause installation issues. However, the "310" might refer to the pywin32 package version rather than Python version, making this suggestion possibly incorrect.
    

    https://pypi.org/project/pywin32/#files

    @jwaisner jwaisner merged commit 023a93e into main Jul 2, 2025
    @jwaisner jwaisner deleted the 3.13.3 branch July 2, 2025 01:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants