Conversation
francoistibo
requested changes
Jun 24, 2022
91b352b to
3f69879
Compare
c2f9f41 to
b7c10c5
Compare
francoistibo
previously approved these changes
Sep 16, 2022
b7485f1 to
2d9b15f
Compare
2d9b15f to
34aafff
Compare
francoistibo
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dans cette PR, on a un second paramètre sur la mixin
headingpour gérer les styles du composantcore/heading. Par défault, nous avons que le style par défaut mais sur certains projets il est possible d'avoir un style particulier. Un exemple concret sur les h2, h3 et h4 qu'on pourrait avoir en uppercase, ça donnerait :_heading.scss_m-heading.scssJe corrige une typo sur les commentaires de certains fichiers
*.scss