VAPI-2714 Update the python SDK to include BRTC endpoint APIs#280
Open
VAPI-2714 Update the python SDK to include BRTC endpoint APIs#280
Conversation
- Introduced `SipCredentials` model for managing SIP connection credentials. - Added documentation for `CreateEndpointRequestBase`, `CreateEndpointResponse`, `CreateEndpointResponseObject`, `CreateWebRtcConnectionRequest`, `Device`, `DeviceStatusEnum`, `Endpoint`, `EndpointDirectionEnum`, `EndpointEvent`, `EndpointEventTypeEnum`, `EndpointResponse`, `EndpointStatusEnum`, `EndpointTypeEnum`, `Endpoints`, `EndpointsApi`, `ErrorResponse`, `ListEndpointsResponse`, `Page`, `SipConnectionMetadata`, and `SipCredentials`. - Implemented example usage in the documentation for each model.
- Implement integration tests for creating, retrieving, listing, and deleting WebRTC endpoints in `test/smoke/test_endpoints_api.py`. - Add unit tests for models related to endpoint requests and responses, including `CreateEndpointRequestBase`, `CreateEndpointResponse`, `CreateEndpointResponseObject`, `Device`, and their respective enums in the `test/unit/models` directory. - Ensure tests cover various scenarios including unauthorized and forbidden access attempts. - Validate the functionality of endpoint events and status enums with dedicated unit tests.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…on fields in ListEndpointsResponse tests
… is not ready yet
…emove forbidden credentials test
…WebRtcConnectionRequest, and Endpoint classes
…reateWebRtcConnectionRequest, and Endpoint classes
…-sdk into brtc-python-sdk
ckoegel
reviewed
Mar 12, 2026
…sponseData; remove redundant tests from existing models
…n with specific exceptions and adding tests for unauthorized, forbidden, and not found scenarios.
…line error scenarios
…-sdk into brtc-python-sdk
ckoegel
reviewed
Mar 23, 2026
- Smoke tests: Replace has_properties with individual assertions, remove hamcrest dependency, add assertions for links/data/errors fields and all properties on response objects, remove AI-generated comments, reuse endpoint ID from create test in delete test - Unit API tests: Remove pagination test, required-only props test, and error handling test; add assertions for tag, devices, and other fields on mocked response data - Unit model tests: Add missing test files for ErrorResponse, Page, SipConnectionMetadata, and SipCredentials models Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Model tests: Replace isinstance checks with value equality for timestamps and add missing field assertions (endpoint_response, list_endpoints_response) - Smoke tests: Add tag assertion on listed endpoint items in listEndpoints - test_list_endpoints_response: Add assertions for page.total_pages and page.page_number, plus value checks on endpoint data fields - Unit API tests: Replace instance_of/is_in with equal_to assertions using expected Prism mock values for endpoint_id, type, status, tag, token, page fields, and error arrays Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…terns - Remove unnecessary assertion in smoke test (listed_ids check) - Replace all hamcrest matchers with plain assert statements in unit API tests - Remove dead make_instance(include_optional) pattern from 13 model tests Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add method (enum: GET/POST/DELETE) to link schema and id, type, source fields to error schema per the authoritative BRTC spec. Extract LinkMethodEnum to its own file to match codebase conventions. Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit a73a50e.
Use assert_that with individual matchers (equal_to, instance_of, not_none, greater_than) to match the assertion style used across all other SDK tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.