Remove redundant feasibility checks from hot prediction paths - #235
Open
Alexander-Mitrofanov wants to merge 1 commit into
Open
Remove redundant feasibility checks from hot prediction paths#235Alexander-Mitrofanov wants to merge 1 commit into
Alexander-Mitrofanov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the first measured phase-3 optimization from discussion #232.
The change removes duplicate accessibility predicates where areComplementary already enforces the same checks. Row-hoisted accessibility screens and recurrence order are retained, so the scientific algorithm and arithmetic are unchanged. A counting regression proves the default seed path no longer repeats the direct accessibility calls.
Validation:
Same-host five-repeat benchmark against 8bd1676:
Evidence: private benchmark commit 5dfd52dc12ff35f5a6bf31f447537eb7460987af; validation Action 31866297250 passed.