Fixing squid:S1118 - Utility classes should not have public constructors

kirill-vlasov · kirill-vlasov · commit c8a750df49d1 · 2015-12-27T21:17:13.000+05:00
diff --git a/caching/src/main/java/com/iluwatar/caching/AppManager.java b/caching/src/main/java/com/iluwatar/caching/AppManager.java
@@ -15,6 +15,9 @@ public class AppManager {
 
   private static CachingPolicy cachingPolicy;
 
+  private AppManager() {
+  }
+
   /**
    *
    * Developer/Tester is able to choose whether the application should use MongoDB as its underlying
diff --git a/caching/src/main/java/com/iluwatar/caching/CacheStore.java b/caching/src/main/java/com/iluwatar/caching/CacheStore.java
@@ -11,6 +11,9 @@ public class CacheStore {
 
   static LruCache cache = null;
 
+  private CacheStore() {
+  }
+
   /**
    * Init cache capacity
    */
diff --git a/caching/src/main/java/com/iluwatar/caching/DbManager.java b/caching/src/main/java/com/iluwatar/caching/DbManager.java
@@ -29,6 +29,9 @@ public class DbManager {
 
   private static HashMap<String, UserAccount> virtualDB;
 
+  private DbManager() {
+  }
+
   /**
    * Create DB
    */
diff --git a/naked-objects/integtests/src/test/java/domainapp/integtests/bootstrap/SimpleAppSystemInitializer.java b/naked-objects/integtests/src/test/java/domainapp/integtests/bootstrap/SimpleAppSystemInitializer.java
@@ -21,6 +21,9 @@
 
 public class SimpleAppSystemInitializer {
 
+  private SimpleAppSystemInitializer() {
+  }
+
   /**
    * Init test system
    */
diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java b/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java
@@ -32,6 +32,9 @@ public class HibernateUtil {
     }
   }
 
+  private HibernateUtil() {
+  }
+
   public static SessionFactory getSessionFactory() {
     return SESSION_FACTORY;
   }
diff --git a/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceLocator.java b/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceLocator.java
@@ -10,6 +10,9 @@ public class ServiceLocator {
 
   private static ServiceCache serviceCache = new ServiceCache();
 
+  private ServiceLocator() {
+  }
+
   /**
    * Fetch the service with the name param from the cache first, if no service is found, lookup the
    * service from the {@link InitContext} and then add the newly created service into the cache map
diff --git a/tolerant-reader/src/main/java/com/iluwatar/tolerantreader/RainbowFishSerializer.java b/tolerant-reader/src/main/java/com/iluwatar/tolerantreader/RainbowFishSerializer.java
@@ -18,6 +18,9 @@
  */
 public class RainbowFishSerializer {
 
+  private RainbowFishSerializer() {
+  }
+
   /**
    * Write V1 RainbowFish to file
    */

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,9 @@ public class AppManager {`
`15`	`15`
`16`	`16`	`private static CachingPolicy cachingPolicy;`
`17`	`17`
	`18`	`+ private AppManager() {`
	`19`	`+ }`
	`20`	`+`
`18`	`21`	`/**`
`19`	`22`	`*`
`20`	`23`	`* Developer/Tester is able to choose whether the application should use MongoDB as its underlying`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@ public class HibernateUtil {`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`
	`35`	`+ private HibernateUtil() {`
	`36`	`+ }`
	`37`	`+`
`35`	`38`	`public static SessionFactory getSessionFactory() {`
`36`	`39`	`return SESSION_FACTORY;`
`37`	`40`	`}`