Hexagonal pattern: Introduce lottery utils class

iseppala · iseppala · commit b030cd4ebafc · 2016-09-17T09:20:33.000+03:00
diff --git a/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryAdministration.java b/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryAdministration.java
@@ -65,7 +65,7 @@ public LotteryNumbers performLottery() {
     LotteryNumbers numbers = LotteryNumbers.createRandom();
     Map<LotteryTicketId, LotteryTicket> tickets = getAllSubmittedTickets();
     for (LotteryTicketId id : tickets.keySet()) {
-      LotteryTicketCheckResult result = new LotteryTicketChecker(repository).checkTicketForPrize(id, numbers);
+      LotteryTicketCheckResult result = LotteryUtils.checkTicketForPrize(repository, id, numbers);
       if (result.getResult().equals(LotteryTicketCheckResult.CheckResult.WIN_PRIZE)) {
         boolean transferred = wireTransfers.transferFunds(LotteryConstants.PRIZE_AMOUNT,
             LotteryConstants.SERVICE_BANK_ACCOUNT, tickets.get(id).getPlayerDetails().getBankAccount());
diff --git a/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryService.java b/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryService.java
@@ -72,6 +72,6 @@ public Optional<LotteryTicketId> submitTicket(LotteryTicket ticket) {
    * Check if lottery ticket has won
    */
   public LotteryTicketCheckResult checkTicketForPrize(LotteryTicketId id, LotteryNumbers winningNumbers) {
-    return new LotteryTicketChecker(repository).checkTicketForPrize(id, winningNumbers);
+    return LotteryUtils.checkTicketForPrize(repository, id, winningNumbers);
   }
 }
diff --git a/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryUtils.java b/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryUtils.java
@@ -27,20 +27,18 @@
 import java.util.Optional;
 
 /**
- * Lottery ticket checker
+ * Lottery utilities
  */
-public class LotteryTicketChecker {
+public class LotteryUtils {
 
-  private final LotteryTicketRepository repository;
-
-  public LotteryTicketChecker(LotteryTicketRepository repository) {
-    this.repository = repository;
+  private LotteryUtils() {
   }
 
   /**
-   * Check if lottery ticket has won
+   * Checks if lottery ticket has won
    */
-  public LotteryTicketCheckResult checkTicketForPrize(LotteryTicketId id, LotteryNumbers winningNumbers) {
+  public static LotteryTicketCheckResult checkTicketForPrize(LotteryTicketRepository repository, LotteryTicketId id,
+                                                      LotteryNumbers winningNumbers) {
     Optional<LotteryTicket> optional = repository.findById(id);
     if (optional.isPresent()) {
       if (optional.get().getNumbers().equals(winningNumbers)) {

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,6 @@ public Optional<LotteryTicketId> submitTicket(LotteryTicket ticket) {`
`72`	`72`	`* Check if lottery ticket has won`
`73`	`73`	`*/`
`74`	`74`	`public LotteryTicketCheckResult checkTicketForPrize(LotteryTicketId id, LotteryNumbers winningNumbers) {`
`75`		`- return new LotteryTicketChecker(repository).checkTicketForPrize(id, winningNumbers);`
	`75`	`+ return LotteryUtils.checkTicketForPrize(repository, id, winningNumbers);`
`76`	`76`	`}`
`77`	`77`	`}`