Skip to content

Commit 5f033be

Browse files
iluwatariluwatar
committed
Fix PMD violations iluwatar#327 
1 parent df911ba commit 5f033be

File tree

94 files changed

+91
-318
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+91
-318
lines changed

‎adapter/src/test/java/com/iluwatar/adapter/AdapterPatternTest.java‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,13 @@
11
package com.iluwatar.adapter;
22

3-
import static org.mockito.Mockito.spy;
4-
import static org.mockito.Mockito.verify;
3+
import org.junit.Before;
4+
import org.junit.Test;
55

66
import java.util.HashMap;
77
import java.util.Map;
88

9-
import org.junit.Before;
10-
import org.junit.Test;
11-
12-
import com.iluwatar.adapter.BattleFishingBoat;
13-
import com.iluwatar.adapter.BattleShip;
14-
import com.iluwatar.adapter.Captain;
15-
import com.iluwatar.adapter.FishingBoat;
9+
import static org.mockito.Mockito.spy;
10+
import static org.mockito.Mockito.verify;
1611

1712
/**
1813
* Test class

‎async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutor.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ void setException(Exception exception) {
102102

103103
@Override
104104
public boolean isCompleted() {
105-
return (state > RUNNING);
105+
return state > RUNNING;
106106
}
107107

108108
@Override

‎async-method-invocation/src/test/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutorTest.java‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,9 @@
88
import java.util.concurrent.Callable;
99
import java.util.concurrent.ExecutionException;
1010

11-
import static org.junit.Assert.assertEquals;
12-
import static org.junit.Assert.assertFalse;
13-
import static org.junit.Assert.assertNotNull;
14-
import static org.junit.Assert.assertSame;
15-
import static org.junit.Assert.assertTrue;
16-
import static org.junit.Assert.fail;
11+
import static org.junit.Assert.*;
1712
import static org.mockito.Matchers.eq;
18-
import static org.mockito.Mockito.mock;
19-
import static org.mockito.Mockito.timeout;
20-
import static org.mockito.Mockito.verify;
21-
import static org.mockito.Mockito.verifyNoMoreInteractions;
22-
import static org.mockito.Mockito.verifyZeroInteractions;
23-
import static org.mockito.Mockito.when;
13+
import static org.mockito.Mockito.*;
2414
import static org.mockito.internal.verification.VerificationModeFactory.times;
2515

2616
/**

‎bridge/src/test/java/com/iluwatar/bridge/AppTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import org.junit.Test;
44

5-
import com.iluwatar.bridge.App;
6-
75
/**
86
*
97
* Application test

‎builder/src/test/java/com/iluwatar/builder/AppTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import org.junit.Test;
44

5-
import com.iluwatar.builder.App;
6-
75
/**
86
*
97
* Application test

‎callback/src/main/java/com/iluwatar/callback/Callback.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
*/
88
public interface Callback {
99

10-
public void call();
10+
void call();
1111
}

‎chain/src/test/java/com/iluwatar/chain/AppTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import org.junit.Test;
44

5-
import com.iluwatar.chain.App;
6-
75
/**
86
*
97
* Application test

‎composite/src/test/java/com/iluwatar/composite/AppTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import org.junit.Test;
44

5-
import com.iluwatar.composite.App;
6-
75
/**
86
*
97
* Application test

‎dao/src/main/java/com/iluwatar/dao/Customer.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public boolean equals(final Object o) {
5555
boolean isEqual = false;
5656
if (this == o) {
5757
isEqual = true;
58-
} else if (o != null && (getClass() == o.getClass())) {
58+
} else if (o != null && getClass() == o.getClass()) {
5959
final Customer customer = (Customer) o;
6060
if (getId() == customer.getId()) {
6161
isEqual = true;

‎decorator/src/test/java/com/iluwatar/decorator/AppTest.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import org.junit.Test;
44

5-
import com.iluwatar.decorator.App;
6-
75
/**
86
*
97
* Application test

0 commit comments

Comments
 (0)