Fix issue in bfs...

mgechev · mgechev · commit 21268fd84d60 · 2014-03-16T14:37:45.000+02:00
diff --git a/src/graphs/searching/bfs.js b/src/graphs/searching/bfs.js
@@ -34,8 +34,8 @@
     function addNode(node) {
       if (visited[node] ||
           node[0] < 0 || node[1] < 0 ||
-          node[0] > graph.length || node[1] > graph[0].length ||
-          !graph[node[0]] || !graph[node[0]]) {
+          node[0] >= graph.length || node[1] >= graph[0].length ||
+          !graph[node[0]][node[1]]) {
         return;
       }
       queue.push(node);
diff --git a/test/graphs/searching/bfs.spec.js b/test/graphs/searching/bfs.spec.js
@@ -1,8 +1,8 @@
 'use strict';
 
-var sampleGraph = [[1, 0, 1, 0, 0, 0],
-                   [0, 1, 0, 1, 0, 0],
-                   [1, 0, 1, 0, 1, 0],
+var sampleGraph = [[1, 1, 1, 0, 0, 0],
+                   [0, 1, 1, 1, 0, 0],
+                   [1, 0, 1, 1, 1, 0],
                    [0, 1, 0, 1, 1, 0],
                    [0, 1, 0, 1, 1, 0],
                    [0, 1, 0, 1, 1, 0],
@@ -47,4 +47,9 @@ describe('BFS', function () {
     expect(bfs(graph, [0, 0], [0, 0])).toBeFalsy();
   });
 
+  it('should work in the general case', function () {
+    expect(bfs(sampleGraph, [0, 0], [1, 1])).toBeTruthy();
+    expect(bfs(sampleGraph, [0, 0], [6, 5])).toBeTruthy();
+  });
+
 });
