Enable Edge API for Platform brokering #8171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalimasharda
reviewed
Dec 2, 2025
sameerag
commented
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces support for platform broker authentication via DOM APIs in Edge browser, allowing direct communication with the platform broker without requiring a browser extension. The PR adds a new allowPlatformBrokerWithDOM configuration flag, includes validation to ensure it's only enabled when allowPlatformBroker is also enabled, and updates documentation to reflect these changes.
Key changes:
- Adds
allowPlatformBrokerWithDOMconfiguration flag with validation that prevents enabling it withoutallowPlatformBroker - Refactors
PlatformAuthProviderto accept DOM support as a parameter instead of reading from session storage, removing the deprecatedisDomEnabledForPlatformAuth()method - Updates documentation to clarify platform broker support across Windows/Mac and describes the new Edge DOM API feature
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/msal-common/src/error/ClientConfigurationErrorCodes.ts | Adds error code for invalid platform broker configuration |
| lib/msal-common/src/error/ClientConfigurationError.ts | Adds error message for the new configuration validation error |
| lib/msal-browser/test/broker/PlatformAuthProvider.spec.ts | Updates tests to pass DOM config as parameter instead of using session storage; removes deprecated tests |
| lib/msal-browser/test/app/PublicClientApplication.spec.ts | Updates test to use new allowPlatformBrokerWithDOM flag instead of session storage |
| lib/msal-browser/src/controllers/StandardController.ts | Passes allowPlatformBrokerWithDOM config to platform provider initialization |
| lib/msal-browser/src/config/Configuration.ts | Defines the new allowPlatformBrokerWithDOM configuration option with default value |
| lib/msal-browser/src/broker/nativeBroker/PlatformAuthProvider.ts | Refactors to accept DOM support as parameter, adds configuration validation, removes deprecated session storage method |
| lib/msal-browser/docs/device-bound-tokens.md | Updates documentation to clarify platform broker support and adds new section for DOM API configuration |
| change/@azure-msal-common-c8d42435-3b15-43cc-9cce-19f00d77e61e.json | Beachball changefile for msal-common package |
| change/@azure-msal-browser-bdb9bd60-08c2-4532-b0cd-2b9830ffa03f.json | Beachball changefile for msal-browser package |
lib/msal-browser/src/broker/nativeBroker/PlatformAuthProvider.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 tasks
Contributor
…8172) - [x] Add test coverage for configuration validation error when allowPlatformBrokerWithDOM is enabled without allowPlatformBroker - [x] Import ClientConfigurationErrorCodes in test file - [x] Verify test passes and linter passes <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sameerag <21958742+sameerag@users.noreply.github.com>
Contributor
Contributor
lalimasharda
approved these changes
Dec 3, 2025
konstantin-msft
approved these changes
Dec 3, 2025
43 tasks
Copilot AI
added a commit
that referenced
this pull request
Dec 3, 2025
- Add allowPlatformBrokerWithDOM configuration flag - Update isPlatformBrokerAvailable to require domConfig as first parameter - Remove deprecated isDomEnabledForPlatformAuth function - Add error validation for invalid platform broker configuration - Update documentation with platform broker terminology and DOM API support Co-authored-by: sameerag <21958742+sameerag@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
allowPlatformBrokerWithDOM), and introduces validation to prevent misconfiguration.