Skip to content

E2E: Add GutenbergCoreE2E TC project - #86949

Merged
fullofcaffeine merged 7 commits into
trunkfrom
add/gutenberg-core-e2e-job
Feb 9, 2024
Merged

fullofcaffeine merged 7 commits into
trunkfrom
add/gutenberg-core-e2e-job

Conversation

@WunderBart

@WunderBart WunderBart commented Jan 29, 2024 •

Copy link
Copy Markdown
Contributor

What?

Add the GutenbergCoreE2E project to enable running the Core E2E tests against Dotcom.

The patched Gutenberg we'll be running the tests from is on WordPress/gutenberg#57342

@github-actions

github-actions Bot commented Jan 29, 2024 •

Copy link
Copy Markdown

@WunderBart

Copy link
Copy Markdown
Contributor Author

@Automattic/team-calypso-platform, I wanted to add a TC project to start running the core E2E tests. This is still in a PoC stage because we need to identify the specs we cannot run due to the environmental discrepancies. Also, the current way we're setting it up might be better in terms of maintenance. At this point, there is no built-in way to override the necessary login and rest E2E utilities, so we need to patch them. It's not a big patch, but it's still a patch rather than a project config.

Regarding the project file itself, since we cannot test it from a branch, I really need some eyes on it. I've never added a project to TC, so I'm not sure if I'm doing anything right here. 🙏

cc: @kevin940726

@fullofcaffeine

fullofcaffeine commented Jan 29, 2024 •

Copy link
Copy Markdown
Contributor

Thanks for working on this! ❤️

Since pretty much we're only adding new artifacts, and as long as IntelliJ is not complaining about compilation errors, merging to test it out should be safe. We can always revert if things go awry. Unfortunately, there's no better way to test, but we already accepted that workflow of merging/reverting as needed for TeamCity.

Regarding the code, it looks good. I'm fine creating a new project for it, but I'm wondering if, since this will be a dotcom-related test, if we should just add the new build under the existing WPCom_Tests project instead?

@WunderBart
WunderBart marked this pull request as ready for review January 30, 2024 13:46
@WunderBart
WunderBart requested a review from a team January 30, 2024 13:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2024
@matticbot

matticbot commented Jan 31, 2024 •

Copy link
Copy Markdown
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@fullofcaffeine

fullofcaffeine commented Jan 31, 2024 •

Copy link
Copy Markdown
Contributor

Thank you again for your work here, Bart! ❤️

I'll try to get it before the EOW to get the build on TC and start experimenting with it!

EDIT: Didn't get to it this week, but will do so the next one.

@fullofcaffeine
fullofcaffeine force-pushed the add/gutenberg-core-e2e-job branch from e296dbc to 66fa092 Compare February 9, 2024 23:01

@fullofcaffeine fullofcaffeine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, let's merge this and see how it'll look like in TC!

@fullofcaffeine
fullofcaffeine merged commit c5962dd into trunk Feb 9, 2024
@fullofcaffeine
fullofcaffeine deleted the add/gutenberg-core-e2e-job branch February 9, 2024 23:17
@github-actions github-actions Bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 9, 2024
TimBroddin pushed a commit that referenced this pull request Feb 20, 2024
* Add GutenbergCoreE2E TC project

* Add missing import

* import settings

* Remove GutenbergCoreE2E.kt

* Add GutenbergCoreE2E to WPComTests project

* Try fixing the syntax

* Fix broken comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants