Domains: Create name-servers component #105062

bogiii · 2025-08-05T10:24:00Z

Part of DOTDASH-201/add-name-servers-editing-screen

Proposed Changes

Creates name-servers component

Follow-up tickets:

Testing Instructions

Go to /v2/domains/{DOMAIN_NAME}/name-servers
Update nameservers
Check the success and error notifications
You can try something like: 'asdf.com', 'asdf2.com'
For success scenario, try "NS4.WORDPRESS.COM" and "NS5.WORDPRESS.COM"

Screen.Recording.2025-08-06.at.19.14.01.mov

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-08-05T10:24:14Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-152581

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-152581&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-152581&env=a8c-for-agencies

hambai

All the components should live under client/dashboard/domains not client/dashboard/sites since all routes are now technically separate from the sites
We have to get rid of the areAllWpcomNameServers function as it's very WPCOM specific and we're trying to make the dashboard agnostic. I'll create a new task to do that as it's a bit complicated
Currently in the domain list data we have a can_manage_name_servers + cannot_manage_name_servers_reason properties - I think on the name-servers screen we should show an error notification if can_manage_name_servers with the text from cannot_manage_name_servers_reason (or a generic message if it's empty)
There are a few other rules that prevent you from managing the domain name servers - mainly (domain.type !== domainTypes.REGISTERED || domain.isGravatarRestrictedDomain). The isGravatarRestrictedDomain is really specific and I wonder if we really need a separate property for it - see

wp-calypso/client/my-sites/domains/domain-management/settings/index.tsx

Line 326 in f87ee02

const renderNameServersSection = () => {

client/dashboard/sites/domains-name-servers/form.tsx

matticbot · 2025-08-07T10:07:42Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~237 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom       +930 B  (+0.1%)     +165 B  (+0.0%)
entry-dashboard-a4a          +927 B  (+0.1%)     +170 B  (+0.0%)
entry-subscriptions          +357 B  (+0.0%)     +104 B  (+0.0%)
entry-stepper                +357 B  (+0.0%)     +104 B  (+0.0%)
entry-reauth-required        +357 B  (+0.0%)     +108 B  (+0.0%)
entry-main                   +357 B  (+0.0%)     +110 B  (+0.0%)
entry-login                  +357 B  (+0.0%)     +108 B  (+0.0%)
entry-domains-landing        +357 B  (+0.1%)     +104 B  (+0.0%)
entry-browsehappy            +357 B  (+0.2%)     +104 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~134 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
sites-dashboard          +551 B  (+0.0%)      +63 B  (+0.0%)
site-settings            +551 B  (+0.0%)      +71 B  (+0.0%)
site-performance         +551 B  (+0.0%)      +63 B  (+0.0%)
site-monitoring          +551 B  (+0.0%)      +63 B  (+0.0%)
site-logs                +551 B  (+0.0%)      +63 B  (+0.0%)
overview                 +551 B  (+0.0%)      +63 B  (+0.0%)
hosting                  +551 B  (+0.0%)      +63 B  (+0.0%)
github-deployments       +551 B  (+0.0%)      +63 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~55 bytes added 📈 [gzipped])

name                       parsed_size           gzip_size
async-load-v-2-sites-list       +551 B  (+0.2%)      +55 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

bogiii · 2025-08-07T10:10:06Z

Currently in the domain list data we have a can_manage_name_servers + cannot_manage_name_servers_reason properties - I think on the name-servers screen we should show an error notification if can_manage_name_servers with the text from cannot_manage_name_servers_reason (or a generic message if it's empty)

There are a few other rules that prevent you from managing the domain name servers - mainly (domain.type !== domainTypes.REGISTERED || domain.isGravatarRestrictedDomain). The isGravatarRestrictedDomain is really specific and I wonder if we really need a separate property for it

Will be handled in the separate task: DOTDASH-254/nameservers-handle-casesrules-that-prevents-nameserver-namagement

cc @hambai

bogiii · 2025-08-07T10:14:06Z

We have to get rid of the areAllWpcomNameServers function as it's very WPCOM specific and we're trying to make the dashboard agnostic. I'll create a new task to do that as it's a bit complicated

Will be handled in the separate task: DOTDASH-255/nameservers-get-rid-of-the-wpcom-specific-methods

cc @hambai

bogiii · 2025-08-07T10:20:04Z

client/dashboard/domains/name-servers/utils.ts

+	return HOSTNAME_REGEX.test( hostname );
+};
+
+export const areAllWpcomNameServers = ( nameservers?: string[] ) => {


This specific WPCOM method will be replaced in the separate PR
DOTDASH-255

bogiii · 2025-08-07T10:33:49Z

client/dashboard/domains/name-servers/index.tsx

+						queryError={ queryError?.message }
+						isBusy={ isUpdatingNameservers }
+						nameservers={ nameservers }
+						onSubmit={ updateNameservers }


In the separate ticket, we will add showUpsellNudge logic.
Ticket: DOTDASH-256/nameservers-update-logic-for-properly-show-upsell-banner

client/dashboard/domains/name-servers/form.tsx

client/dashboard/app-dotcom/index.tsx

client/dashboard/data/domain-nameservers.ts

client/dashboard/domains/name-servers/form-input.tsx

client/dashboard/domains/name-servers/form.tsx

client/dashboard/domains/name-servers/utils.ts

client/dashboard/domains/name-servers/upsell-nudge.tsx

bogiii · 2025-08-07T12:24:01Z

client/dashboard/domains/name-servers/upsell-nudge.tsx

+					text={ __( 'Upgrade plan' ) }
+					tracksId="dseployments"
+					variant="primary"
+					href={ `/checkout/${ domainName }/business` }


The domainName should be a siteSlug. It will be done once we merge the: 189995-ghe-Automattic/wpcom
Follow up ticket: DOTDASH-256

client/dashboard/app/queries/domain-nameservers.ts

client/dashboard/data/domain-nameservers.ts

client/dashboard/domains/name-servers/styles.scss

client/dashboard/domains/name-servers/form.tsx

client/dashboard/app/queries/domain-nameservers.ts

client/dashboard/domains/name-servers/styles.scss

client/dashboard/app-dotcom/index.tsx

client/dashboard/app/queries/domain-name-servers.ts

client/dashboard/domains/name-servers/form-input.tsx

p-jackson · 2025-08-11T05:18:24Z

client/dashboard/domains/name-servers/index.tsx

+	const { instanceType } = useAppContext();
+	const { domainName } = domainRoute.useParams();
+	const { createSuccessNotice, createErrorNotice } = useDispatch( noticesStore );
+	const { data: nameServers, error: queryError } = useQuery( domainNameServersQuery( domainName ) );


Is this domain name servers query something we should fetch in the router? That way we can use suspense here

Suggested change

const { data: nameServers, error: queryError } = useQuery( domainNameServersQuery( domainName ) );

const { data: nameServers, error: queryError } = useSuspenseQuery( domainNameServersQuery( domainName ) );

I would not fetch name servers data in the router with Suspense because we want fine-grained control over error handling in the UI.

Using Suspense with useSuspenseQuery would force us to handle errors at a route level through error boundaries, which would be a worse user experience than our current approach of showing inline errors following design.

Interesting, yeah the design has this new pattern for showing error

QOBjujZah0UlGDDdLKZhzi-fi-10344_149770

It's a new thing that we have not used in existing code; we can rethink later on how we should handle this case 🤔

client/dashboard/domains/name-servers/upsell-nudge.tsx

client/dashboard/domains/name-servers/form.tsx

client/dashboard/app-dotcom/index.tsx

client/dashboard/data/domain-name-servers.ts

github-actions · 2025-08-11T18:21:05Z

Design System Reference Site Preview:

https://513f4311-preview.a8cds.workers.dev

(Latest commit: 5faf3ad)

fushar

I have the same comment as: #105113 (comment)

Basically, let's rename the directory to domains/domain-name-servers for consistency.

client/dashboard/app/queries/domain-name-servers.ts

fushar · 2025-08-14T11:01:33Z

client/dashboard/domains/name-servers/index.tsx

+	const { instanceType } = useAppContext();
+	const { domainName } = domainRoute.useParams();
+	const { createSuccessNotice, createErrorNotice } = useDispatch( noticesStore );
+	const { data: nameServers, error: queryError } = useQuery( domainNameServersQuery( domainName ) );


Interesting, yeah the design has this new pattern for showing error

QOBjujZah0UlGDDdLKZhzi-fi-10344_149770

It's a new thing that we have not used in existing code; we can rethink later on how we should handle this case 🤔

client/dashboard/domains/name-servers/index.tsx

client/dashboard/domains/name-servers/form.tsx

fushar

Generally this looks good. I still have the same comment #105062 (review)

We can iterate in follow-up PRs if needed.

bogiii · 2025-08-14T12:25:00Z

Thanks @fushar, I'm going to deploy this one, and we can iterate on it in the follow-up PRs.

matticbot · 2025-08-14T12:38:01Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/DOTDASH-201 on your sandbox.

a8ci18n · 2025-08-14T13:23:34Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/19840779

Some locales (Brazilian Portuguese, Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @bogiii for including a screenshot in the description! This is really helpful for our translators.

* Create name-servers component

* Created the initial structure for the the /contact-info route * Added some initial components to the screen * Using DataForm for domain Contact details * Finished the first interface version * Reading Contact information from /whois endpoint * Validating data before saving Contact Info * Update Contact details data using backend API * Added isDurty state for the save button * Added basic validation on DataForm * Getting supported contries list from our API * Add support to opt-out 60-day option * Add Save contact info warning * Add support to State selection from selected country * Move country and state logic to inside the contact form component * Fix re-render issue that removed the focus from text input while typing * Add eslint rule to prevent lodash usage * Refactor domain-supported contries and states and removed lodash usage * Move mutate events to contact-form * My Jetpack: Updating user connection page header and button text. (#105149) * Substack Import: fix flow bug (#105167) * Only display error message in the expiry column in the Site Overview (#105168) * Enable summer special (#105169) * Site Overview: Implement renew now action (#105160) * Site Overview: Implement renew now action * Fix types * Use replaceAll * Redirect by window.location.href * Increase timeout between atomic transfer and redirect (#105174) * Increase timeout between atomic transfer and redirect * Remove unnecessary delay * Connect Refresh: Extract Gravatar Magic Login into its own space (#104863) * Connect Refresh: Extract Gravatar Magic Login into its own space * whole lotta love * migrate styles * cleanup. fix publicToken use? * unfix publicToken use? * cmon. works now * fix loginUrl * lots of cleanup * fix form outlines * fix navigation to login * extract inner components into outer scope * extract inner components into outer scope * cleanup. address feedback * cleanup * Update client/login/magic-login/gravatar/style.scss Co-authored-by: Welly Shen <hivoid19@gmail.com> * address feedback. progress on code-validated * fix interval not resetting * fix code validation transition * Update client/login/magic-login/gravatar/index.tsx Co-authored-by: Welly Shen <hivoid19@gmail.com> * Update client/login/magic-login/gravatar/index.tsx Co-authored-by: Welly Shen <hivoid19@gmail.com> * Update client/login/magic-login/gravatar/index.tsx Co-authored-by: Welly Shen <hivoid19@gmail.com> * cleanup redirect --------- Co-authored-by: Welly Shen <hivoid19@gmail.com> * Connect Refresh: Migrate Akismet create-account to unified Signup (#105116) * Fixes the Promote Post version check hook (#105163) * Allow plugins upload for plans without sftp (#105176) * Connect Refresh: Migrate VIP create-account to unified Signup (#105132) * Remove Summer Special install plugin feature from Business and Ecommerce (#105177) * Updating @wordpress/components and @wordpress/dataviews packages (#105142) * Updating @wordpress/components and @wordpress/dataviews packages * Fix plugin icon * Fix site icon --------- Co-authored-by: arthur <arthur.chu@automattic.com> * Fix font size when rendering ZD HTML (#105180) * Site settings: add missing learn more links (#105150) * Staging Sites Redesign: Update Tooltip and checkbox disable style (#105158) * Improve styles * Ensure we have checkbox * Fix both disabaled and checked * Fix tooltip position * Clean comments * Update message * Fix typo * Break tooltip in two lines * Allow full sync when selective sync is not disabled --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> * Hosting Dashboard: Add site logs initial dataviews with data (#105118) * Connect Refresh: Migrate Jetpack Cloud create-account to unified Signup (#105178) * add null checks (#105165) * Staging Sites: Notify syncing after completing the endpoint call (#105112) * Staging Sites: Notify syncing after completing the endpoint call * Add the callback to the pull action too * Disable sync button immediately after starting syncing * Check inflight mutations to disable Sync button * close modal after mutation completes --------- Co-authored-by: Gergely Csécsey <gcsecsey@gmail.com> * Connect Refresh: Migrate Studio create-account to unified Signup (#105133) * Components: Fix ambiguous `rem()` import (#103385) * Domains Hosting Dashboard: Create "Add new DNS record" page (#105095) * (WIP) Create "Add new DNS record" page to Hosting Dashboard * Create forms to add all supported DNS record types * Remove some console.logs and refactor some code * Refactor code splitting the form configuration for each record type in its own file * Fix field types and add "required" validation * Add trailing dot automatically for fields that need to be a FQDN * Use text area component for TXT record data * Add description field for DNS records * Remove empty default element from select fields * Make placeholders translatable * Reset form data when changing record types * Navigate to DNS overview page when clicking on "Cancel" * Remove query that does not belong to this PR * Refactor DNSRecord type * Consolidate component in /dns/add/index.tsx * Rename `AddDNSRecordFormData` to `DNSRecordFormData` and fix form typing * Remove `isValid` properties from DNS record configs * Move DNS record configs to types file * Rename `types.ts` to `dns-record-configs.ts` * Small refactor * Replace straight quote mark by a curly quote mark * Do not translate DNS record types (e.g. A, ALIAS, CNAME) * Navigate to DNS overview page after adding a record * Remove translation from CAA tags * Improve FQDN comment in the data transformation function * Remove translations from SRV protocol labels * Translate placeholder strings for DNS records * Translate page title * Remove `WPCOMDNSRecord` that was not being used * Fix type error because ALIAS did not have a `name` property * Update type names and definitions to align with #105129 * Update type names to keep consistency * Update mutation function to a more generic one * Update mutation function to align with #105129 * A4A > Sign up: Show Onboarding tour in WC flow (#105175) * Jetpack Cloud: skip wpcomJetpackScanAtomicTransfer middleware on Cloud and A4A (#105189) * Staging Sites: Add separate expand button and allow selecting nodes by clicking on them in the Jetpack Backup FileBrowser (#105161) * Allow selecting files by clicking on them * Add separate expand button option to file browser component * Remove unnecessary min-width * Correct grammar in a comment * Fix styling * Add RTL support for chevrons * Improve checkbox accessibility * Adjust accessibility * Remove tab index from the node button only when `showFileCard` option is disabled * Add `expandDirectoriesOnClick` prop to control directory expansion behavior in file browser * Introduce separate `handleExpandButtonClick` handler * Expansion directories only when `expandDirectoriesOnClick` prop is true * Simplify checkbox change logic * Improve contents of --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> * Redirect from deletion banner when the staging site is deleted (#105164) * redirect from deletion banner when the staging site is deleted * check if query is undefined * use calypso/state notices instead of snackbar * clean up comments * CalloutOverlay: Fix the overlapping issue (#105195) * Fix section name in track events (#105196) * Hosting Dashboard: Add domain glue records DataView (#105184) * ZD: Fix metadata when creating a ticket (#105183) * Packages: Add domain-search to tsconfig (#105186) * Dashboard v2: render expiring purchase in color (#105170) * Gravatar: Adjust login-related screens for Gravatar-owned services (#105192) * Gravatar: Adjust login-related screens for Gravatar owned services * Reuse one more variable --------- Co-authored-by: Welly Shen <welly.shen@automattic.com> * Domain Dashboard: Render registered date and renewal CTA (#105188) * Render the header and registered date * Render the renew now button if eligible * Wrap domain name if it doesnt fit in the container * Use purchase properties * Revert callback changes * Hosting dashboard: Add a custom empty state to the site list (#104544) * Backups Dashboard: add back up now button (#105190) * Add enqueue and fetch backup functions * Add siteBackupsQuery * Add BackupNowButton * Render BackupNowButton as Backups page header action * Remove backup up now button icon * Refactor BackupNowButton: Simplify button content and tooltip handling - Moved button content and tooltip text into a structured object for better readability and maintainability. - Updated mutation function to set the enqueue state before calling the backup function. * Removed unnecessary empty object from the post request * Refactor backup data layer to entity/collection pattern * Domains Hosting Dashboard: DNS records list (#105129) * Add dns list placeholder * Add basic data * Implement data view * Add value column * Update section header * Hide DataView header * Add actions placeholders * Add action menu placeholder * Update dns record list - handle protected records * Move action to a separate file * Move fields in a separate file * Add restore default records actions placeholders * Add logit to enable/disable dns actions * Work in progress * Add delete/edit callback * Minor fixes after rebase * Fix edit dns route * Implement domain restore actions * Fine tuning * Fix type issue * Restore params * Fix type error * Restore DnsRecordType * Fix type * Address PR review comments * Fix dropdown * Address PR review comments * Add more tracking information around creating conversations (#105199) * Fix double login e2e (#101899) * Site Overview: Implement change site address action (#105191) * Site Overview: Implement change site address action * Fix types * Update eslint * Address feedback * Fix display incorrect wpcom domain * fix(sites): prevent PreviewSizePicker crash from invalid previewSize … (#105206) * fix(sites): prevent PreviewSizePicker crash from invalid previewSize values * Move previewSize sanitization to existing `sanitizeView` function * Simplify code for updating `previewSize` to a valid value * Use `undefined` instead of `230` in order to explicitly get the default * Check whether the previewSize is smaller than the smallest value * Check whether the previewSize is NaN --------- Co-authored-by: Arun <arun@arun.blog> Co-authored-by: arthur <arthur.chu@automattic.com> * Domains: Create name-servers component (#105062) * Create name-servers component * Marketplace Site Selector: Fix highlight styles within component (#105047) * Fix styles within component * Improve syntax * Remove content-fade * Cleanup comments * Remove unnecessary overide * Keep fade in * Revert reader changes * Update colors and fade in * Improve fade in removal * Ensure the hover state on badges remain the same * Only apply the overrides for specific badges * Fix unintended changes * Fix unintended change * Remove redundant styles --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> * Add the hosting dashboard domain forwarding add/edit form (#105113) The Hosting Dashboard add and edit form for Domain Forwarding rules. There are a few follow up tasks that we'll fix * Newsletter importer: Update billing warning copy (#105203) * Newsletter importer: Update billing warning copy. * Connect Refresh: Fix layout issues with Woo DNA/JPC signup (create-account) form (#105156) * Domain Search: Update experiment name (#105131) * Domain Search: Update experiment name * Enable eligibility only for logged in users --------- Co-authored-by: Luis Felipe Zaguini <luisfelipezaguini@gmail.com> * Getting supported contries list from our API * Fix merge conflict * Add support to State selection from selected country * Refactor domain-supported contries and states and removed lodash usage * Remove unnecessary code after merge * Renamed contact-details directory to domain-contact-details * Update domain data type and removed types file * Use contact-form-fields to store them so the main file doesn't get too big * Final review changes * Removed unnecessary css files and fixed types * Readability improvements * Fix data types * Improve support links usage * Improve the usage of queries for validate mutation * Fix unnecessary type mapping and remove older query * Fix type error on StateFieldEdit component * Fix render error during component update --------- Co-authored-by: Grzegorz Chudzinski-Pawlowski <112354940+grzegorz-cp@users.noreply.github.com> Co-authored-by: Tony Arcangelini <33258733+arcangelini@users.noreply.github.com> Co-authored-by: Griffith Chen <griffith.chen@automattic.com> Co-authored-by: Veselin Nikolov <veselin@automattic.com> Co-authored-by: arthur791004 <arthur.chu@automattic.com> Co-authored-by: Claudiu Filip <claudiu.filip@automattic.com> Co-authored-by: Christos <chriskmnds@gmail.com> Co-authored-by: Welly Shen <hivoid19@gmail.com> Co-authored-by: Sebastián Barbosa <sebabarbosa@gmail.com> Co-authored-by: Omar Alshaker <omar@omaralshaker.com> Co-authored-by: Ashar Fuadi <ashar.fuadi@automattic.com> Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com> Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> Co-authored-by: Karen Attfield <karenlattfield@gmail.com> Co-authored-by: Gergely Csécsey <gergely.csecsey@automattic.com> Co-authored-by: Roberto Aranda <roberto.aranda@automattic.com> Co-authored-by: Gergely Csécsey <gcsecsey@gmail.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: leonardost <leonardost@users.noreply.github.com> Co-authored-by: Yashwin Poojary <yashwinpoojary@gmail.com> Co-authored-by: Rafael Agostini <rafael.agostini@automattic.com> Co-authored-by: Ivan Ottinger <ivan.ottinger@automattic.com> Co-authored-by: Miroslav Mitev <m1r0@users.noreply.github.com> Co-authored-by: Payton Swick <payton@automattic.com> Co-authored-by: Welly Shen <welly.shen@automattic.com> Co-authored-by: Luis Felipe Zaguini <26530524+zaguiini@users.noreply.github.com> Co-authored-by: Philip Jackson <p-jackson@users.noreply.github.com> Co-authored-by: Igor Giussani <igor.giussani@automattic.com> Co-authored-by: Arun <arun@arun.blog> Co-authored-by: Bogdan Nikolic <bogdan.nikolic87@gmail.com> Co-authored-by: Kamen Stanev <kamen.stanev@automattic.com> Co-authored-by: Allison Levine <1689238+allilevine@users.noreply.github.com> Co-authored-by: Luis Felipe Zaguini <luisfelipezaguini@gmail.com>

bogiii self-assigned this Aug 5, 2025

bogiii changed the title ~~Update/dotdash 201~~ Domains: Create name-servers component Aug 5, 2025

bogiii force-pushed the update/DOTDASH-201 branch from 0f30442 to 0161dc0 Compare August 5, 2025 17:02

hambai requested changes Aug 6, 2025

View reviewed changes

hambai reviewed Aug 6, 2025

View reviewed changes

client/dashboard/sites/domains-name-servers/form.tsx Outdated Show resolved Hide resolved

bogiii force-pushed the update/DOTDASH-201 branch from a182bec to dbf79b4 Compare August 7, 2025 09:57

bogiii commented Aug 7, 2025

View reviewed changes

bogiii requested a review from hambai August 7, 2025 10:40

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 7, 2025

bogiii requested a review from a team August 7, 2025 10:40

bogiii marked this pull request as ready for review August 7, 2025 10:41

bogiii requested a review from a team as a code owner August 7, 2025 10:41

bogiii force-pushed the update/DOTDASH-201 branch from fb7e61e to d761216 Compare August 7, 2025 12:12

bogiii commented Aug 7, 2025

View reviewed changes

client/dashboard/domains/name-servers/form.tsx Show resolved Hide resolved

zaguiini reviewed Aug 7, 2025

View reviewed changes

bogiii commented Aug 7, 2025

View reviewed changes

client/dashboard/domains/name-servers/upsell-nudge.tsx Outdated Show resolved Hide resolved

bogiii commented Aug 7, 2025

View reviewed changes

fushar reviewed Aug 7, 2025

View reviewed changes

client/dashboard/app/queries/domain-nameservers.ts Outdated Show resolved Hide resolved

bogiii force-pushed the update/DOTDASH-201 branch from f42e688 to ea59678 Compare August 8, 2025 09:50

p-jackson reviewed Aug 11, 2025

View reviewed changes

arthur791004 reviewed Aug 11, 2025

View reviewed changes

client/dashboard/domains/name-servers/form.tsx Outdated Show resolved Hide resolved

client/dashboard/app-dotcom/index.tsx Outdated Show resolved Hide resolved

client/dashboard/data/domain-name-servers.ts Outdated Show resolved Hide resolved

bogiii marked this pull request as draft August 11, 2025 11:19

bogiii force-pushed the update/DOTDASH-201 branch from 6657a4b to 7ceebb3 Compare August 11, 2025 12:01

bogiii added 4 commits August 13, 2025 16:52

Remove custom style

93bb847

Add missing dependency

92b6b5c

Remove unnecessary class name

5c3ae6e

Make sure the query cache reflects the updated data immediately

6462fcb

bogiii marked this pull request as ready for review August 13, 2025 15:22

bogiii requested review from a team, arthur791004, fushar, p-jackson, youknowriad and zaguiini August 13, 2025 15:22

bogiii added 3 commits August 13, 2025 23:57

Transform value to be a lowercase

b3f1c80

Optimize how the callback is being provide

4e5f396

Transform value to lowercase

c557b16

fushar reviewed Aug 14, 2025

View reviewed changes

bogiii added 4 commits August 14, 2025 13:50

Remove spread operator

355ad54

Remove unnecessary optimization

f8420f3

Remove unnecessary extra VStack wrapper

8b069ad

Replace View component with basic div

aee76a4

bogiii requested a review from fushar August 14, 2025 12:06

fushar approved these changes Aug 14, 2025

View reviewed changes

Remove the old serviceName field

dc74205

bogiii merged commit b9d79c1 into trunk Aug 14, 2025
11 checks passed

bogiii deleted the update/DOTDASH-201 branch August 14, 2025 12:44

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 14, 2025

paulopmt1 pushed a commit that referenced this pull request Aug 14, 2025

Domains: Create name-servers component (#105062)

d26cabd

* Create name-servers component

	const { data: nameServers, error: queryError } = useQuery( domainNameServersQuery( domainName ) );
	const { data: nameServers, error: queryError } = useSuspenseQuery( domainNameServersQuery( domainName ) );

Domains: Create name-servers component #105062

Domains: Create name-servers component #105062

Uh oh!

Conversation

bogiii commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Testing Instructions

Pre-merge Checklist

Uh oh!

github-actions bot commented Aug 5, 2025 • edited by matticbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hambai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matticbot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bogiii commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bogiii commented Aug 7, 2025

Uh oh!

bogiii Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bogiii Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bogiii Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

p-jackson Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

bogiii Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

fushar Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

fushar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fushar Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bogiii commented Aug 5, 2025 •

edited

Loading

github-actions bot commented Aug 5, 2025 •

edited by matticbot

Loading

matticbot commented Aug 7, 2025 •

edited

Loading

bogiii commented Aug 7, 2025 •

edited

Loading

bogiii Aug 7, 2025 •

edited

Loading

a8ci18n commented Aug 14, 2025 •

edited

Loading