-
Notifications
You must be signed in to change notification settings - Fork 2k
Hosting dashboard: Add a custom empty state to the site list #104544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9fcf280
Switch "Add New Button" to sentence case
p-jackson 25fd8e9
Adds an empty site component to the site list
p-jackson 4359f85
Fix the broken illustration
p-jackson 3b92b8f
Transform into generic EmptyState component
p-jackson 7237b82
Adjust styles for consistent spacing and mobile layout
p-jackson cd5588f
Rename props to be consistent with other HD prop names
p-jackson 952e670
Renames to `DataViewsEmptyState`
p-jackson ee2f3f7
Storybook for empty state
p-jackson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { | ||
| __experimentalVStack as VStack, | ||
| __experimentalHStack as HStack, | ||
| } from '@wordpress/components'; | ||
| import './styles.scss'; | ||
| import { Text } from '../text'; | ||
| import type { ReactNode } from 'react'; | ||
|
|
||
| interface EmptyStateProps { | ||
| actions?: ReactNode; | ||
| description: string; | ||
| illustration?: ReactNode; | ||
| title: string; | ||
| } | ||
|
|
||
| export function EmptyState( { actions, title, illustration, description }: EmptyStateProps ) { | ||
| return ( | ||
| <VStack spacing={ 6 } alignment="center" className="dashboard-empty-state"> | ||
| { illustration } | ||
| <VStack spacing={ 2 } alignment="center"> | ||
| <div className="dashboard-empty-state__heading">{ title }</div> | ||
| <Text variant="muted" align="center" className="dashboard-empty-state__sub-heading"> | ||
| { description } | ||
| </Text> | ||
| </VStack> | ||
| { actions && ( | ||
| <HStack spacing={ 4 } justify="center" wrap> | ||
| { actions } | ||
| </HStack> | ||
| ) } | ||
| </VStack> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| @import "@wordpress/base-styles/variables"; | ||
| @import "@wordpress/base-styles/mixins"; | ||
|
|
||
| .dashboard-empty-state { | ||
| max-width: 480px; | ||
| padding-block: $grid-unit-20; | ||
| box-sizing: border-box; | ||
|
|
||
| img { | ||
| width: 100%; | ||
| } | ||
| } | ||
|
|
||
| .dashboard-empty-state__heading { | ||
| @include heading-x-large; | ||
| color: $gray-900; | ||
| margin: 0; | ||
| } | ||
|
|
||
| // Balanced wrapping works better for centered text | ||
| // Extra specificity to override <Text> component styles | ||
| .dashboard-empty-state .dashboard-empty-state__sub-heading { | ||
| text-wrap: balance; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it would be better to update the classname as well
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was already working on it 😄
FORCE PUSH!!