Hosting dashboard: Add a custom empty state to the site list #104544

p-jackson · 2025-07-02T04:23:52Z

Part of DOTDASH-14

Proposed Changes

Note

In light of ARC-422 (merging dataviews back to core) there are parts of this PR that will need to reworked.

Creates new <EmptyState>, based on this experimental DS component rykv85Ii9RkvP504dtqqaW-fi-158_50621 QOBjujZah0UlGDDdLKZhzi-fi-2587_192468
Site list shows an EmptyState in its DataViews if the user has no sites or if the filter/search returns no results
"Add new site" button which opens the same modal as the header action button
"Clear search" button clears just the text search, not all filters
- @matt-west should the button actually reset all filters to default?
Fixes sentence casing of "Add new site" button and modal title

Not in this PR

Adding a min-height to the dataview as discussed here p1751440760784079/1751428514.884869-slack-C05QAFZSFTL

New user with no sites

This can happen for example if a user created a WordPress.com account at some stage just to comment on a blog. And they come to the dashboard at a later date.

Text search returns no results (grid mode)

Text search returns no results (table mode)

When the table needs to scroll the empty state sticks where it is.

CleanShot.2025-08-13.at.16.58.50.mp4

It seems a little odd, but this is how core already works. If we want to propose something better we should upstream that improvement.

@matt-west the text wrapping here doesn't match Figma, despite the fact I'm using the same container size. But I don't think it makes sense to sweat over the wrapping. The user's search term appears in the copy so there's not much we can do about it. No using balanced wrapping.

Grid mode on phone

Table mode on phone

Why are these changes being made?

When a data view is empty, it can be useful to give the user a call-to-action, so they can start populating the data view.

The "empty state" component is marked as experimental, so I've added it to the dashboard code rather than promoting it to @automattic/components.

Testing Instructions

Test the site list at calypso.localhost:3000/v2
Test the backport at calypso.localhost:3000/sites

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-07-02T04:24:03Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-152547

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-152547&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-152547&env=a8c-for-agencies

matticbot · 2025-07-02T04:34:15Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~44 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom       +134 B  (+0.0%)      +44 B  (+0.0%)
entry-dashboard-a4a          +134 B  (+0.0%)      +44 B  (+0.0%)
entry-subscriptions           +68 B  (+0.0%)      +23 B  (+0.0%)
entry-stepper                 +68 B  (+0.0%)      +23 B  (+0.0%)
entry-reauth-required         +68 B  (+0.0%)      +23 B  (+0.0%)
entry-main                    +68 B  (+0.0%)      +23 B  (+0.0%)
entry-login                   +68 B  (+0.0%)      +23 B  (+0.0%)
entry-domains-landing         +68 B  (+0.0%)      +23 B  (+0.0%)
entry-browsehappy             +68 B  (+0.0%)      +23 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~46 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site             +150 B  (+0.0%)      +46 B  (+0.0%)
sites-dashboard          +150 B  (+0.0%)      +46 B  (+0.0%)
site-settings            +150 B  (+0.0%)      +46 B  (+0.0%)
site-performance         +150 B  (+0.0%)      +46 B  (+0.0%)
site-monitoring          +150 B  (+0.0%)      +46 B  (+0.0%)
site-logs                +150 B  (+0.0%)      +46 B  (+0.0%)
plans                    +150 B  (+0.0%)      +46 B  (+0.0%)
overview                 +150 B  (+0.0%)      +46 B  (+0.0%)
hosting                  +150 B  (+0.0%)      +46 B  (+0.0%)
github-deployments       +150 B  (+0.0%)      +46 B  (+0.0%)
domains                  +150 B  (+0.0%)      +46 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~35 bytes added 📈 [gzipped])

name                       parsed_size           gzip_size
async-load-v-2-sites-list        +66 B  (+0.1%)      +35 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

arthur791004 · 2025-07-04T05:13:15Z

We have to split the changes of the Dataviews to Gutenberg.

p-jackson · 2025-07-04T05:19:13Z

client/dashboard/sites/index.tsx


+	const hasFilterOrSearch = ( view.filters && view.filters.length > 0 ) || view.search;
+
+	const emptyHeading = hasFilterOrSearch ? __( 'No sites found' ) : __( 'No sites' );


When choosing the copy to show, having some sort of filter takes precedence over having no sites. That might be counter intuitive.

My first instinct was that "No sites" should take precedence. If a user has zero sites and they type in a search, surely the more important message is that the user has no sites.

But it is a little more nuanced. By default we do not show "hidden" sites. But then when the user starts typing, we assume that maybe they're looking for a specific hidden site and so start showing them.

So when the user sees the "No sites" message, we don't actually know whether the user has literally no sites 😳

And when the user starts searching, they might be looking for a hidden site, and so it is better to show the message "No sites found".

p-jackson · 2025-07-04T07:41:53Z

We have to split the changes of the Dataviews to Gutenberg.

Yes, I added a note about that in the PR description. I'm hoping to get some feedback about the empty state, but ultimately I need to open some GB PRs to get this whole thing merged.

Tweaks one of the data view padding styles that was missed in #104479

@arthur791004 Since this PR also adds an extra style rule that should have been in #104479, do you think it makes sense to just merge that in to wp-calypso so all those style changes get considered as one when merging into upstream?

arthur791004 · 2025-07-04T07:47:35Z

so all those style changes get considered as one when merging into upstream?

It has been merged into upstream via WordPress/gutenberg#70567, so any further changes should now be made directly in the upstream 😅

matt-west

Thanks @p-jackson!

should the button actually reset all filters to default?

Yes, because you could see the empty state after only applying filters. Ideally the button text would be conditional, so it would say Clear search, Clear filters, or Clear search and filters depending on what the user has applied.

the text wrapping here doesn't match Figma, despite the fact I'm using the same container size.

We could use text-wrap: balance; here to make the wrapping feel a bit better.

We should drop the column headers when the empty state is shown.

Let’s centre the empty state in the container. At the moment it appears to be top-aligned.

I noticed a small error in the illustration which has now been fixed in Figma. Can you please grab the updated version here.

p-jackson · 2025-07-08T00:25:50Z

Adding an empty prop in GB WordPress/gutenberg#70637

p-jackson · 2025-07-08T02:14:07Z

Adding the padding fix to GB WordPress/gutenberg#70638

p-jackson · 2025-07-25T08:24:19Z

Abandoned WordPress/gutenberg#70637
Opened WordPress/gutenberg#70867 to create a consistent customisable empty state in all dataviews.

p-jackson · 2025-08-13T05:03:16Z

Blast from the past! With the empty prop now shipped in the latest dataviews package, this custom empty state should now be good to go.

arthur791004 · 2025-08-13T08:36:49Z

client/dashboard/components/empty-state/index.tsx

+	subHeading: string;
+}
+
+export function EmptyState( { buttons, heading, illustration, subHeading }: EmptyStateProps ) {


I'm not sure whether it's our common design pattern for ALL empty state. Would it be better to specific to DataViews?

That was my original idea, but the Figma for EmptyState seems to imply it could be used anywhere rykv85Ii9RkvP504dtqqaW-fi-158_50622

It is marked as "experimental" though, so perhaps we shouldn't put too much weight on it.

In v1 we have empty states all over the place, but now that I think of it, most places where there might be an empty state in the HD we would already be using a data view. The only other empty state I think of would be some sort of block canvas which is empty 🤔

So perhaps for the HD purpose it really should be called the DataViewsEmptyState.

client/dashboard/components/empty-state/index.tsx

matticbot · 2025-08-13T22:12:22Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug DOTDASH-14/add-empty-site-list-state on your sandbox.

arthur791004

👍

arthur791004 · 2025-08-14T02:11:39Z

client/dashboard/components/empty-state/styles.scss

+	}
+}
+
+.dashboard-empty-state__heading {


nit: it would be better to update the classname as well

I was already working on it 😄

FORCE PUSH!!

a8ci18n · 2025-08-14T04:20:11Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/19834801

Some locales (Brazilian Portuguese, Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @p-jackson for including a screenshot in the description! This is really helpful for our translators.

* Created the initial structure for the the /contact-info route * Added some initial components to the screen * Using DataForm for domain Contact details * Finished the first interface version * Reading Contact information from /whois endpoint * Validating data before saving Contact Info * Update Contact details data using backend API * Added isDurty state for the save button * Added basic validation on DataForm * Getting supported contries list from our API * Add support to opt-out 60-day option * Add Save contact info warning * Add support to State selection from selected country * Move country and state logic to inside the contact form component * Fix re-render issue that removed the focus from text input while typing * Add eslint rule to prevent lodash usage * Refactor domain-supported contries and states and removed lodash usage * Move mutate events to contact-form * My Jetpack: Updating user connection page header and button text. (#105149) * Substack Import: fix flow bug (#105167) * Only display error message in the expiry column in the Site Overview (#105168) * Enable summer special (#105169) * Site Overview: Implement renew now action (#105160) * Site Overview: Implement renew now action * Fix types * Use replaceAll * Redirect by window.location.href * Increase timeout between atomic transfer and redirect (#105174) * Increase timeout between atomic transfer and redirect * Remove unnecessary delay * Connect Refresh: Extract Gravatar Magic Login into its own space (#104863) * Connect Refresh: Extract Gravatar Magic Login into its own space * whole lotta love * migrate styles * cleanup. fix publicToken use? * unfix publicToken use? * cmon. works now * fix loginUrl * lots of cleanup * fix form outlines * fix navigation to login * extract inner components into outer scope * extract inner components into outer scope * cleanup. address feedback * cleanup * Update client/login/magic-login/gravatar/style.scss Co-authored-by: Welly Shen <hivoid19@gmail.com> * address feedback. progress on code-validated * fix interval not resetting * fix code validation transition * Update client/login/magic-login/gravatar/index.tsx Co-authored-by: Welly Shen <hivoid19@gmail.com> * Update client/login/magic-login/gravatar/index.tsx Co-authored-by: Welly Shen <hivoid19@gmail.com> * Update client/login/magic-login/gravatar/index.tsx Co-authored-by: Welly Shen <hivoid19@gmail.com> * cleanup redirect --------- Co-authored-by: Welly Shen <hivoid19@gmail.com> * Connect Refresh: Migrate Akismet create-account to unified Signup (#105116) * Fixes the Promote Post version check hook (#105163) * Allow plugins upload for plans without sftp (#105176) * Connect Refresh: Migrate VIP create-account to unified Signup (#105132) * Remove Summer Special install plugin feature from Business and Ecommerce (#105177) * Updating @wordpress/components and @wordpress/dataviews packages (#105142) * Updating @wordpress/components and @wordpress/dataviews packages * Fix plugin icon * Fix site icon --------- Co-authored-by: arthur <arthur.chu@automattic.com> * Fix font size when rendering ZD HTML (#105180) * Site settings: add missing learn more links (#105150) * Staging Sites Redesign: Update Tooltip and checkbox disable style (#105158) * Improve styles * Ensure we have checkbox * Fix both disabaled and checked * Fix tooltip position * Clean comments * Update message * Fix typo * Break tooltip in two lines * Allow full sync when selective sync is not disabled --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> * Hosting Dashboard: Add site logs initial dataviews with data (#105118) * Connect Refresh: Migrate Jetpack Cloud create-account to unified Signup (#105178) * add null checks (#105165) * Staging Sites: Notify syncing after completing the endpoint call (#105112) * Staging Sites: Notify syncing after completing the endpoint call * Add the callback to the pull action too * Disable sync button immediately after starting syncing * Check inflight mutations to disable Sync button * close modal after mutation completes --------- Co-authored-by: Gergely Csécsey <gcsecsey@gmail.com> * Connect Refresh: Migrate Studio create-account to unified Signup (#105133) * Components: Fix ambiguous `rem()` import (#103385) * Domains Hosting Dashboard: Create "Add new DNS record" page (#105095) * (WIP) Create "Add new DNS record" page to Hosting Dashboard * Create forms to add all supported DNS record types * Remove some console.logs and refactor some code * Refactor code splitting the form configuration for each record type in its own file * Fix field types and add "required" validation * Add trailing dot automatically for fields that need to be a FQDN * Use text area component for TXT record data * Add description field for DNS records * Remove empty default element from select fields * Make placeholders translatable * Reset form data when changing record types * Navigate to DNS overview page when clicking on "Cancel" * Remove query that does not belong to this PR * Refactor DNSRecord type * Consolidate component in /dns/add/index.tsx * Rename `AddDNSRecordFormData` to `DNSRecordFormData` and fix form typing * Remove `isValid` properties from DNS record configs * Move DNS record configs to types file * Rename `types.ts` to `dns-record-configs.ts` * Small refactor * Replace straight quote mark by a curly quote mark * Do not translate DNS record types (e.g. A, ALIAS, CNAME) * Navigate to DNS overview page after adding a record * Remove translation from CAA tags * Improve FQDN comment in the data transformation function * Remove translations from SRV protocol labels * Translate placeholder strings for DNS records * Translate page title * Remove `WPCOMDNSRecord` that was not being used * Fix type error because ALIAS did not have a `name` property * Update type names and definitions to align with #105129 * Update type names to keep consistency * Update mutation function to a more generic one * Update mutation function to align with #105129 * A4A > Sign up: Show Onboarding tour in WC flow (#105175) * Jetpack Cloud: skip wpcomJetpackScanAtomicTransfer middleware on Cloud and A4A (#105189) * Staging Sites: Add separate expand button and allow selecting nodes by clicking on them in the Jetpack Backup FileBrowser (#105161) * Allow selecting files by clicking on them * Add separate expand button option to file browser component * Remove unnecessary min-width * Correct grammar in a comment * Fix styling * Add RTL support for chevrons * Improve checkbox accessibility * Adjust accessibility * Remove tab index from the node button only when `showFileCard` option is disabled * Add `expandDirectoriesOnClick` prop to control directory expansion behavior in file browser * Introduce separate `handleExpandButtonClick` handler * Expansion directories only when `expandDirectoriesOnClick` prop is true * Simplify checkbox change logic * Improve contents of --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> * Redirect from deletion banner when the staging site is deleted (#105164) * redirect from deletion banner when the staging site is deleted * check if query is undefined * use calypso/state notices instead of snackbar * clean up comments * CalloutOverlay: Fix the overlapping issue (#105195) * Fix section name in track events (#105196) * Hosting Dashboard: Add domain glue records DataView (#105184) * ZD: Fix metadata when creating a ticket (#105183) * Packages: Add domain-search to tsconfig (#105186) * Dashboard v2: render expiring purchase in color (#105170) * Gravatar: Adjust login-related screens for Gravatar-owned services (#105192) * Gravatar: Adjust login-related screens for Gravatar owned services * Reuse one more variable --------- Co-authored-by: Welly Shen <welly.shen@automattic.com> * Domain Dashboard: Render registered date and renewal CTA (#105188) * Render the header and registered date * Render the renew now button if eligible * Wrap domain name if it doesnt fit in the container * Use purchase properties * Revert callback changes * Hosting dashboard: Add a custom empty state to the site list (#104544) * Backups Dashboard: add back up now button (#105190) * Add enqueue and fetch backup functions * Add siteBackupsQuery * Add BackupNowButton * Render BackupNowButton as Backups page header action * Remove backup up now button icon * Refactor BackupNowButton: Simplify button content and tooltip handling - Moved button content and tooltip text into a structured object for better readability and maintainability. - Updated mutation function to set the enqueue state before calling the backup function. * Removed unnecessary empty object from the post request * Refactor backup data layer to entity/collection pattern * Domains Hosting Dashboard: DNS records list (#105129) * Add dns list placeholder * Add basic data * Implement data view * Add value column * Update section header * Hide DataView header * Add actions placeholders * Add action menu placeholder * Update dns record list - handle protected records * Move action to a separate file * Move fields in a separate file * Add restore default records actions placeholders * Add logit to enable/disable dns actions * Work in progress * Add delete/edit callback * Minor fixes after rebase * Fix edit dns route * Implement domain restore actions * Fine tuning * Fix type issue * Restore params * Fix type error * Restore DnsRecordType * Fix type * Address PR review comments * Fix dropdown * Address PR review comments * Add more tracking information around creating conversations (#105199) * Fix double login e2e (#101899) * Site Overview: Implement change site address action (#105191) * Site Overview: Implement change site address action * Fix types * Update eslint * Address feedback * Fix display incorrect wpcom domain * fix(sites): prevent PreviewSizePicker crash from invalid previewSize … (#105206) * fix(sites): prevent PreviewSizePicker crash from invalid previewSize values * Move previewSize sanitization to existing `sanitizeView` function * Simplify code for updating `previewSize` to a valid value * Use `undefined` instead of `230` in order to explicitly get the default * Check whether the previewSize is smaller than the smallest value * Check whether the previewSize is NaN --------- Co-authored-by: Arun <arun@arun.blog> Co-authored-by: arthur <arthur.chu@automattic.com> * Domains: Create name-servers component (#105062) * Create name-servers component * Marketplace Site Selector: Fix highlight styles within component (#105047) * Fix styles within component * Improve syntax * Remove content-fade * Cleanup comments * Remove unnecessary overide * Keep fade in * Revert reader changes * Update colors and fade in * Improve fade in removal * Ensure the hover state on badges remain the same * Only apply the overrides for specific badges * Fix unintended changes * Fix unintended change * Remove redundant styles --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> * Add the hosting dashboard domain forwarding add/edit form (#105113) The Hosting Dashboard add and edit form for Domain Forwarding rules. There are a few follow up tasks that we'll fix * Newsletter importer: Update billing warning copy (#105203) * Newsletter importer: Update billing warning copy. * Connect Refresh: Fix layout issues with Woo DNA/JPC signup (create-account) form (#105156) * Domain Search: Update experiment name (#105131) * Domain Search: Update experiment name * Enable eligibility only for logged in users --------- Co-authored-by: Luis Felipe Zaguini <luisfelipezaguini@gmail.com> * Getting supported contries list from our API * Fix merge conflict * Add support to State selection from selected country * Refactor domain-supported contries and states and removed lodash usage * Remove unnecessary code after merge * Renamed contact-details directory to domain-contact-details * Update domain data type and removed types file * Use contact-form-fields to store them so the main file doesn't get too big * Final review changes * Removed unnecessary css files and fixed types * Readability improvements * Fix data types * Improve support links usage * Improve the usage of queries for validate mutation * Fix unnecessary type mapping and remove older query * Fix type error on StateFieldEdit component * Fix render error during component update --------- Co-authored-by: Grzegorz Chudzinski-Pawlowski <112354940+grzegorz-cp@users.noreply.github.com> Co-authored-by: Tony Arcangelini <33258733+arcangelini@users.noreply.github.com> Co-authored-by: Griffith Chen <griffith.chen@automattic.com> Co-authored-by: Veselin Nikolov <veselin@automattic.com> Co-authored-by: arthur791004 <arthur.chu@automattic.com> Co-authored-by: Claudiu Filip <claudiu.filip@automattic.com> Co-authored-by: Christos <chriskmnds@gmail.com> Co-authored-by: Welly Shen <hivoid19@gmail.com> Co-authored-by: Sebastián Barbosa <sebabarbosa@gmail.com> Co-authored-by: Omar Alshaker <omar@omaralshaker.com> Co-authored-by: Ashar Fuadi <ashar.fuadi@automattic.com> Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com> Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> Co-authored-by: Karen Attfield <karenlattfield@gmail.com> Co-authored-by: Gergely Csécsey <gergely.csecsey@automattic.com> Co-authored-by: Roberto Aranda <roberto.aranda@automattic.com> Co-authored-by: Gergely Csécsey <gcsecsey@gmail.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: leonardost <leonardost@users.noreply.github.com> Co-authored-by: Yashwin Poojary <yashwinpoojary@gmail.com> Co-authored-by: Rafael Agostini <rafael.agostini@automattic.com> Co-authored-by: Ivan Ottinger <ivan.ottinger@automattic.com> Co-authored-by: Miroslav Mitev <m1r0@users.noreply.github.com> Co-authored-by: Payton Swick <payton@automattic.com> Co-authored-by: Welly Shen <welly.shen@automattic.com> Co-authored-by: Luis Felipe Zaguini <26530524+zaguiini@users.noreply.github.com> Co-authored-by: Philip Jackson <p-jackson@users.noreply.github.com> Co-authored-by: Igor Giussani <igor.giussani@automattic.com> Co-authored-by: Arun <arun@arun.blog> Co-authored-by: Bogdan Nikolic <bogdan.nikolic87@gmail.com> Co-authored-by: Kamen Stanev <kamen.stanev@automattic.com> Co-authored-by: Allison Levine <1689238+allilevine@users.noreply.github.com> Co-authored-by: Luis Felipe Zaguini <luisfelipezaguini@gmail.com>

p-jackson self-assigned this Jul 2, 2025

p-jackson force-pushed the DOTDASH-14/add-empty-site-list-state branch 2 times, most recently from 659ce4e to 96458db Compare July 4, 2025 04:33

p-jackson marked this pull request as ready for review July 4, 2025 04:57

p-jackson requested review from a team and youknowriad as code owners July 4, 2025 04:57

matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 4, 2025

p-jackson commented Jul 4, 2025

View reviewed changes

p-jackson changed the title ~~Adds empty prop to DataViews component for rendering empty states~~ Hosting dashboard: Add a custom empty state to the site list Jul 4, 2025

matt-west reviewed Jul 4, 2025

View reviewed changes

p-jackson force-pushed the DOTDASH-14/add-empty-site-list-state branch from 96458db to d39cbee Compare July 8, 2025 05:23

p-jackson added 3 commits August 13, 2025 15:35

Switch "Add New Button" to sentence case

9fcf280

Adds an empty site component to the site list

25fd8e9

Fix the broken illustration

4359f85

p-jackson force-pushed the DOTDASH-14/add-empty-site-list-state branch from d39cbee to 4359f85 Compare August 13, 2025 03:45

p-jackson added 2 commits August 13, 2025 16:13

Transform into generic EmptyState component

3b92b8f

Adjust styles for consistent spacing and mobile layout

7237b82

p-jackson removed request for a team and youknowriad August 13, 2025 05:02

p-jackson added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Aug 13, 2025

arthur791004 reviewed Aug 13, 2025

View reviewed changes

Rename props to be consistent with other HD prop names

cd5588f

p-jackson force-pushed the DOTDASH-14/add-empty-site-list-state branch from a78a739 to cd5588f Compare August 13, 2025 22:06

arthur791004 approved these changes Aug 14, 2025

View reviewed changes

p-jackson added 2 commits August 14, 2025 14:19

Renames to DataViewsEmptyState

952e670

Storybook for empty state

ee2f3f7

p-jackson merged commit 334636c into trunk Aug 14, 2025
11 checks passed

p-jackson deleted the DOTDASH-14/add-empty-site-list-state branch August 14, 2025 02:53

github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Aug 14, 2025

paulopmt1 pushed a commit that referenced this pull request Aug 14, 2025

Hosting dashboard: Add a custom empty state to the site list (#104544)

38d9abf


		const hasFilterOrSearch = ( view.filters && view.filters.length > 0 ) \|\| view.search;

		const emptyHeading = hasFilterOrSearch ? __( 'No sites found' ) : __( 'No sites' );

Hosting dashboard: Add a custom empty state to the site list #104544

Hosting dashboard: Add a custom empty state to the site list #104544

Uh oh!

Conversation

p-jackson commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

Uh oh!

github-actions bot commented Jul 2, 2025 • edited by matticbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matticbot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arthur791004 commented Jul 4, 2025

Uh oh!

p-jackson Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

p-jackson commented Jul 4, 2025

Uh oh!

arthur791004 commented Jul 4, 2025

Uh oh!

matt-west left a comment

Choose a reason for hiding this comment

Uh oh!

p-jackson commented Jul 8, 2025

Uh oh!

p-jackson commented Jul 8, 2025

Uh oh!

p-jackson commented Jul 25, 2025

Uh oh!

p-jackson commented Aug 13, 2025

Uh oh!

arthur791004 Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

p-jackson Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matticbot commented Aug 13, 2025

Uh oh!

arthur791004 left a comment

Choose a reason for hiding this comment

Uh oh!

arthur791004 Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

p-jackson Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

a8ci18n commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

p-jackson commented Jul 2, 2025 •

edited

Loading

github-actions bot commented Jul 2, 2025 •

edited by matticbot

Loading

matticbot commented Jul 2, 2025 •

edited

Loading

p-jackson Jul 4, 2025 •

edited

Loading

p-jackson Aug 14, 2025 •

edited

Loading

a8ci18n commented Aug 14, 2025 •

edited

Loading