Repository navigation
Search Dashboard: restore visible space between "AI Answers" and "(Preview)" tab label - #48850
Merged
Merged
Conversation
…eview)" tab label
The new flex-based `Tabs.Tab` from `@wordpress/components` collapses
JSX `{ ' ' }` whitespace between sibling nodes, so the "(Preview)"
suffix rendered flush against "AI Answers". Move a non-breaking
space inside the preview-label span so it survives the flex layout.
Follow-up to #48846 (review comment #3245711759).
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
Bot
added
the
[Package] Search
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
Bot
added
the
[Status] Needs Author Reply
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
github-actions
Bot
removed
the
[Status] Needs Author Reply
6 tasks
kangzj
added a commit
that referenced
this pull request
May 15, 2026
…ipt (RSM-3319) Replace the parenthesized inline label "(Preview)" sitting in a plain <span> next to the AI Answers tab title with a semantic <sup> superscript and drop the parens. Visually this leans on the UA's own `vertical-align: super` baseline shift; we only override the font-size (0.7em) and tint the text with the neutral-weak design token so the qualifier reads as metadata instead of competing with the tab title. The translation call moves to _x() with a context note so translators see the badge intent. Removes the ` ` workaround that #48850 had to add against the new flex-based Tabs.Tab — putting the text inside <sup> means the UA superscript handles its own spacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes nothing — follow-up to #48846 review comment #48846 (comment).
Proposed changes
dashboard-page.jsx, the "AI Answers (Preview)" tab label was rendering asAI Answers(Preview)after the migration to the unifiedTabs.Tab(variant"minimal") chassis from@wordpress/components. The new flex-based tab layout collapses the JSX{ ' ' }text node sitting between two sibling elements, so the visible separator disappeared.{ ' ' }and instead place a non-breaking space ( ) inside the.jp-search-dashboard-tabs__tab-preview-label<span>itself, right before the localized(Preview)string. A space inside the element's text content is not subject to flex sibling-whitespace collapsing, so the gap renders reliably.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jp build search --deps.