tsgo: Fix type errors in forms, shared-extension-utils, woocommerce-analytics, and jetpack by manzoorwanijk · Pull Request #47423 · Automattic/jetpack

manzoorwanijk · 2026-03-03T08:34:13Z

Completes MONOREP-383, MONOREP-384, MONOREP-385

Proposed changes:

js-packages/shared-extension-utils: Add @typedef for ModuleStatus return type; add @deprecated to getJetpackData().
packages/forms: Tighten JSDoc @return/@typedef tags; patch @wordpress/interactivity@6.40.0 to fix incomplete Window.scheduler type (upstream fix: Interactivity: Fix incomplete Window.scheduler type causing TS2430 in downstream projects WordPress/gutenberg#76070).
packages/woocommerce-analytics: Change randomBytes type to Uint8Array<ArrayBuffer> to match crypto.getRandomValues return type.
plugins/jetpack (AI Assistant block): Replace deprecated getJetpackData()?.adminUrl with getMyJetpackUrl() from @automattic/jetpack-script-data.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Run pnpm typecheck
All should exit cleanly with no errors.

Changelog

Generate changelog entries for this PR (using AI).

github-actions · 2026-03-03T08:35:10Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/tsgo/fix-type-errors-in-multiple-packages branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/tsgo/fix-type-errors-in-multiple-packages

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/tsgo/fix-type-errors-in-multiple-packages

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-03-03T08:35:28Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copilot

Pull request overview

This PR addresses TypeScript (tsgo) type errors across several packages in the monorepo, including Jetpack, Forms, WooCommerce Analytics, and shared extension utilities, and adds a pnpm patch for a WordPress dependency type issue.

Changes:

Update Jetpack AI Assistant to use getMyJetpackUrl() instead of deprecated getJetpackData()?.adminUrl composition.
Tighten/clarify JSDoc types (@typedef, @return) in Forms and shared-extension-utils; deprecate getJetpackData().
Add a pnpm patched dependency for @wordpress/interactivity@6.40.0 to adjust Window.scheduler typings; update lockfile accordingly.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
projects/plugins/jetpack/extensions/blocks/ai-assistant/hooks/use-ai-product-page/index.ts	Switches My Jetpack URL generation to `getMyJetpackUrl()`
projects/plugins/jetpack/changelog/update-tsgo-fix-type-errors-in-multiple-packages	Jetpack changelog entry for TS type fixes
projects/packages/woocommerce-analytics/src/client/utils.ts	Adjusts `randomBytes` typing in `generateRandomToken()`
projects/packages/woocommerce-analytics/changelog/update-tsgo-fix-type-errors-in-multiple-packages	WooCommerce Analytics changelog entry
projects/packages/forms/src/store/form-step-preview.js	Adds `StepInfo` typedef and tightens selector return type
projects/packages/forms/src/blocks/shared/hooks/use-find-block-recursively.js	Adds `Block` typedef and tightens hook return type
projects/packages/forms/src/blocks/contact-form/components/jetpack-integration-controls.js	Tightens return type to `ReactNode`
projects/packages/forms/changelog/update-tsgo-fix-type-errors-in-multiple-packages	Forms changelog entry
projects/js-packages/shared-extension-utils/src/hooks/use-module-status/index.js	Adds `ModuleStatus` typedef for hook return type
projects/js-packages/shared-extension-utils/src/get-jetpack-data.js	Marks `getJetpackData()` deprecated
projects/js-packages/shared-extension-utils/changelog/update-tsgo-fix-type-errors-in-multiple-packages	shared-extension-utils changelog entry
pnpm-workspace.yaml	Adds patched dependency entry for `@wordpress/interactivity@6.40.0`
pnpm-lock.yaml	Records the patch hash/path for the patched dependency
.pnpm-patches/@wordpress__interactivity@6.40.0.patch	Patch modifying `Window.scheduler` type shape in `@wordpress/interactivity`

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

projects/packages/woocommerce-analytics/src/client/utils.ts:31

randomBytes is never initialized when window.crypto.getRandomValues is unavailable, but it’s still written to in the fallback loop (randomBytes[i] = ...). This will throw at runtime on environments without crypto (and TS can’t catch it here). Initialize randomBytes in the else branch (e.g., allocate a Uint8Array(randomBytesLength) before the loop) or refactor the fallback to build an array and convert it before encoding.

	let randomBytes: Uint8Array< ArrayBuffer >;

	if ( window.crypto && window.crypto.getRandomValues ) {
		randomBytes = new Uint8Array( randomBytesLength );
		window.crypto.getRandomValues( randomBytes );
	} else {
		for ( let i = 0; i < randomBytesLength; ++i ) {
			randomBytes[ i ] = Math.floor( Math.random() * 256 );
		}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jp-launch-control · 2026-03-03T08:53:46Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

projects/packages/woocommerce-analytics/src/client/utils.ts:31

In the non-crypto fallback branch, randomBytes is never initialized before assigning randomBytes[i], which would throw at runtime if that branch is reached. Consider initializing randomBytes (e.g., allocate the Uint8Array up front) before the if so both branches write into a valid buffer.

export function generateRandomToken( randomBytesLength: number ): string {
	let randomBytes: Uint8Array< ArrayBuffer >;

	if ( window.crypto && window.crypto.getRandomValues ) {
		randomBytes = new Uint8Array( randomBytesLength );
		window.crypto.getRandomValues( randomBytes );
	} else {
		for ( let i = 0; i < randomBytesLength; ++i ) {
			randomBytes[ i ] = Math.floor( Math.random() * 256 );
		}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

simison

Forms 👍

manzoorwanijk added 4 commits March 3, 2026 13:46

Fix type errors in js-packages/shared-extension-utils

040c5fe

Fix type errors in forms package

13f0f47

Fix TS type for randomBytes in WC Analytics

89bb3f4

Fix type error in Jetpack AI block

cdf5867

manzoorwanijk requested review from a team March 3, 2026 08:34

manzoorwanijk self-assigned this Mar 3, 2026

Copilot AI review requested due to automatic review settings March 3, 2026 08:34

manzoorwanijk added [Status] Needs Review This PR is ready for review. Code Quality labels Mar 3, 2026

Copilot started reviewing on behalf of manzoorwanijk March 3, 2026 08:34

View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread .pnpm-patches/@wordpress__interactivity@6.40.0.patch

Comment thread .pnpm-patches/@wordpress__interactivity@6.40.0.patch

Comment thread projects/js-packages/shared-extension-utils/src/get-jetpack-data.js Outdated

Fix typo in return comment

2ecb70f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 3, 2026 08:53

Copilot started reviewing on behalf of manzoorwanijk March 3, 2026 08:53

View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread projects/packages/forms/src/blocks/shared/hooks/use-find-block-recursively.js

simison approved these changes Mar 3, 2026

View reviewed changes

manzoorwanijk merged commit 1fc9cd6 into trunk Mar 3, 2026
97 checks passed

manzoorwanijk deleted the update/tsgo/fix-type-errors-in-multiple-packages branch March 3, 2026 09:40

github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Mar 3, 2026

Navigation Menu

Repository navigation

tsgo: Fix type errors in forms, shared-extension-utils, woocommerce-analytics, and jetpack - #47423

tsgo: Fix type errors in forms, shared-extension-utils, woocommerce-analytics, and jetpack#47423
manzoorwanijk merged 5 commits into
trunkfrom
update/tsgo/fix-type-errors-in-multiple-packages

manzoorwanijk commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jp-launch-control Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

simison left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

manzoorwanijk commented Mar 3, 2026

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Changelog

Uh oh!

github-actions Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jp-launch-control Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

simison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Mar 3, 2026 •

edited

Loading

github-actions Bot commented Mar 3, 2026 •

edited

Loading

jp-launch-control Bot commented Mar 3, 2026 •

edited

Loading