Skip to content

Improve sidebar form column detection - #553

Merged
chubes4 merged 1 commit into
trunkfrom
artist-surfaces-20260706
Jul 6, 2026
Merged

chubes4 merged 1 commit into
trunkfrom
artist-surfaces-20260706

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Ignore HTML comments when evaluating candidate column containers.
  • Treat a form-tagged sibling as the content pane when paired with a sidebar child.
  • Add contract coverage for a commented sidebar-plus-form layout converting to native columns.

Verification

  • php tests/contract/run.php
  • php tests/unit/button-signal-classifier.php
  • Direct Artist contact transform emits one core/columns block.
  • SSI Artist focused surface matrix rerun: run id 9091e2c3-efeb-42d6-a48e-76245048b8f5, still failing on remaining visual/editor/runtime blockers.

AI assistance

  • AI assistance: Yes
  • Tool(s): GPT-5.5 via OpenCode
  • Used for: Investigation, implementation, focused verification, and PR drafting.

@chubes4
chubes4 merged commit dd56cbd into trunk Jul 6, 2026
1 check passed
@chubes4
chubes4 deleted the artist-surfaces-20260706 branch July 6, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant