feat(kb): expose resumable upload task status - #9639
Open
lxfight wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
size:L
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The per-file task metadata structure is duplicated in multiple places (init_task, update_progress, background_*), which makes it easy to introduce inconsistencies; consider extracting a small helper for creating/updating file entries to centralize this logic.
- update_progress returns silently when task_id is unknown or file_index is out of range, which can hide misuses or bugs; adding explicit logging or raising a clear error in these cases would make failures easier to diagnose.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The per-file task metadata structure is duplicated in multiple places (init_task, update_progress, background_*), which makes it easy to introduce inconsistencies; consider extracting a small helper for creating/updating file entries to centralize this logic.
- update_progress returns silently when task_id is unknown or file_index is out of range, which can hide misuses or bugs; adding explicit logging or raising a clear error in these cases would make failures easier to diagnose.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications / 改动点
Backend / 后端
Frontend / 前端
主要修改文件：
dashboard/src/views/knowledge-base/components/DocumentsTab.vue- 任务状态显示dashboard/src/api/generated/openapi-v1.ts- API 类型定义改动统计： +636/-37 行
Screenshots or Test Results / 运行截图或测试结果
测试场景：
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试，并已在上方提供了验证步骤和运行截图。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。